Repository navigation
Conversation
…ettings clear The session and settings codecs each carried a copy of the value-line check and of the read-a-line loop. Both now come from store/codec_text.h. The settings store's clear was a wrapper around indigo_file_remove used only by the tests, so the tests call indigo_file_remove directly. No behaviour change: host tests stay at 4037 checks, 0 failures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
Owner
Author
|
Superseded by the replacement PR: same refactor on a fresh branch from main, because this one conflicted with the v0.39.0 pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the store part of #53. The session and settings codecs each had a copy of the value-line check and of the read-a-line loop; both now use
src/store/codec_text.h. The settings store'sclearwas a wrapper aroundindigo_file_removethat only the tests called, so it is gone and the tests callindigo_file_removedirectly.What changed
src/store/codec_text.h:indigo_codec_has_breakandindigo_codec_next_line, inline.session_codec.candsettings_codec.cuse them. The settings decoder keeps its CRLF tolerance.indigo_settings_store_clearremoved (it was test-only).indigo_session_store_clearstays, sincesession_auth.cuses it.Scope and what was not done
src/store/file.con main, and the three stores use it. Nothing to move there.--min-tokens 80 --min-lines 12finds no clones insrc/store. The issue's store and session-store clone numbers no longer match main.src/atproto/session_read.c,session_people.candsession_lists.cjob functions still have repeated shapes. They are compiled only for 3DS, so this PR does not touch them, andsession_auth.candsignin.care untouched (PR feat(signin): password sign-in finds the PDS from the handle #72).indigo_media_knownandindigo_layout_hitfrom the issue's cppcheck list.Verification
make test: 4037 checks, 0 failures, before and after.make warnings: clean.makewith devkitARM, Wolfram v0.38.0): builds.Notes
Net line count is roughly neutral: 29 lines added and 48 removed in tracked files, plus the new 36-line header.
🤖 Generated with Claude Code