Repository navigation
refactor(store): share the codec line reader and drop the test-only settings clear - #75
Merged
Merged
Conversation
…ettings clear The session and settings codecs each carried a copy of the value-line check and of the read-a-line loop. Both now come from store/codec_text.h. The settings store's clear was a wrapper around indigo_file_remove used only by the tests, so the tests call indigo_file_remove directly. No behaviour change: host tests stay at 4037 checks, 0 failures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Replaces #73 (conflicted with main after the v0.39.0 pin). Same refactor as #75; this copy is closed in favour of #75.
Shares the codec line reader between the session and settings codecs, and removes a test-only wrapper around file removal.
Verification
Host:
make test4063 checks, 0 failures. Pinned to Wolfram v0.39.0 on main. Not run on a 3DS or in Azahar.Docs
Docs: none (internal refactor; behaviour unchanged).
Changelog: CHANGELOG.md
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code