Repository navigation
feat(signin): password sign-in finds the PDS from the handle - #72
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Blocked on Wolfram v0.38.0, which is not released yet. Do not merge until that release exists and wolfram.ref is bumped to it; this PR leaves wolfram.ref at v0.37.0 on purpose, so the 3DS link will fail on v0.37.0 until then.
The app-password sign-in no longer needs the PDS host.
indigo_session_do_logincalls Wolfram'swf_agent_login_discovered, which resolves the handle or DID, points the agent at the account's #atproto_pds endpoint and logs in there. The discovered PDS is whatremembersaves, so a resume goes straight to it. An empty Service falls back to INDIGO_DEFAULT_SERVICE (https://bsky.social) as the starting host.The sign-in form is ready from a handle alone when a password is given. The Service field stays required for the browser (OAuth node) sign-in, which has no discovery step. The not-ready message now names the missing field.
Depends on: Wolfram v0.38.0 (
wf_agent_login_discovered, from ewanc26/wolfram#187, not yet released).Verification
Host:
make testpasses, 4046 checks, 0 failures. Covers the readiness rule: a handle alone is ready for a password sign-in, an empty handle never is, and the browser sign-in needs a Service.make warningsis clean. 3DS:make wolfram-3dsthenmakelinks indigo.3dsx against the feat/discover-pds checkout of Wolfram. Not run on a 3DS or in Azahar, and the discovery request has not been seen against a live PDS.Docs
CHANGELOG.md: a Changed entry under [Unreleased] that links this PR. Blocked on Wolfram v0.38.0.
Changelog: Signing in with an app password needs only the handle; the Service field is kept for the browser sign-in.
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code