Repository navigation
refactor: remove the duplicated store, session and touch code - #60
Merged
Merged
Conversation
Add store/file: the session, settings and draft stores each carried their own copy of write-to-temp-and-rename, bounded read and move-aside. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Four small commits that remove copies: the session, settings and draft stores each had their own write-to-temp-and-rename, bounded read and move-aside (now
src/store/file.c); the timeline and the thread had the same touch actions (post_list_touch);session.crepeated the failure report thirteen times and the actor-page tail three (publish_failure,publish_actor_page). A last commit fixes the one warning the 3DS build printed: a release version too long for the update event is refused rather than truncated. jscpd (60 tokens) goes from 1.53% to 0.80% duplicated lines insrc. Part of #53.Verification
Host:
make test(4019 checks, 0 failures under ASan and UBSan; a new test covers the file helpers),make warningsclean. The 3DS build (devkitARM) links with no warnings. The session changes are only compiled for the 3DS, so they are covered by that build and by CI, not by a test, and nothing ran on Azahar or a 3DS.Docs
AGENTS.md and CHANGELOG updated.
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code