Repository navigation
refactor: duplicated store and session code #53
Description
Activity
Progress: duplicated lines in
srcwent from 1.53% to 0.80% (#60), andsession.c,app.candlayout.care split into smaller files (#61, #62, #64). What is left is small (thedo_*job wrappers insession_people.candsession_lists.cstill repeat their fetch-fill-publish shape). Leaving this open for that.Fixed in v0.12.1: session-agent guard macro (INDIGO_SESSION_AGENT_GUARD) applied; session_people.c / session_lists.c verified.
I want no duplicated code in Indigo. A clone scan (
jscpd --min-tokens 80 --min-lines 12oversrc/) finds six clones: 42 lines insidesrc/atproto/session.c, 26 betweensrc/store/session_store.candsettings_store.c, 15 betweendraft_store.candsession_store.c(the read-a-small-file and write-it-atomically shape three times), 23 insidesrc/app/app.c(the list-screen update handlers), and 15 intools/snapshot.c.What I want: one small-file store helper (read, write atomically, bounds) that the three stores use, the session job functions folded onto one request/result pattern, and the list screens' update handlers sharing one function. One PR each, host tests green, no behaviour change.
Also from
cppcheck --enable=unusedFunction(after #52 removed the one with no callers):indigo_media_known,indigo_layout_hitandindigo_settings_store_clearare called only by the tests; each should be a real API or go.Written by Claude on my behalf.