Repository navigation
fix(ui): unwind nested thread and profile screens one step at a time - #238
Merged
Merged
Conversation
Each thread or profile opened from another one overwrote the single return slot, so B from an inner thread went to the profile, and B from there went back to the outer thread, which then pointed at the profile again. Nothing ever got back to the timeline. Thread and profile now push the screen they were opened from onto a return stack, and B pops it. The snapshot suite walks timeline, thread, profile, thread and asserts each step returns to the previous screen. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The flow-extra check asks for docs to move with code. The parity row for #110 described the timeline cursor only; it now covers the nested chain too. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Backing out of a thread opened from a profile that was itself opened from a thread bounced between the profile and the outer thread, so the timeline was never reached. Thread and profile now push the screen they were opened from onto a return stack, and B pops it, in place of the single return slots that the nested route overwrote. Refs #110.
Verification
Host only, no console.
make test(1254 checks, 0 failures).make -C tests snapshot(332 checks, 0 failures), including a new nested-route assertion that walks timeline, thread, profile, thread, back to the timeline. Before the fix the same walk looped between the profile and the outer thread.Docs
CHANGELOG entry under Unreleased (Fixed). PARITY.md's #110 row is unchanged; it still describes the timeline cursor case rather than this nested chain.
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code