Skip to content

fix(ui): fetch the outer thread again when unwinding to it - #239

Open
ewanc26 wants to merge 2 commits into
mainfrom
fix/nested-thread-refetch
Open

ewanc26 wants to merge 2 commits into
mainfrom
fix/nested-thread-refetch

Conversation

@ewanc26

@ewanc26 ewanc26 commented Oct 17, 2026

Copy link
Copy Markdown
Owner

What this changes

Follow-up to #238, which is merged. Unwinding to an outer thread restored its screen, but the session still held the inner conversation, so the outer thread showed the wrong conversation. Each return-stack entry now records the thread it showed, and going back to a thread requests that thread again. Refs #110.

Verification

Host only, no console. make test: 1254 checks, 0 failures on the rerun. One earlier run failed a timing-dependent async login check, which passed on the next two runs. make -C tests snapshot: 333 checks, 0 failures. A mutation check that disables the refetch makes the new assertion fail, then passes once restored.

Docs

CHANGELOG entry under Unreleased (Fixed). PARITY.md's #110 row already describes the nested chain; the refetch is a detail under it.

Checklist

  • CI is green (CI gate and flow / conventions)
  • No secrets, tokens or signing keys in the diff
  • Tests added or changed with the behaviour; none skipped, disabled or deleted

🤖 Generated with Claude Code

ewanc26 and others added 2 commits October 17, 2026 15:37
The return stack unwound to the outer thread, but the session still held
the inner conversation, so the outer screen showed the wrong thread. Each
return now records the thread it showed, and going back to a thread
requests it again. A test counts that request, so it does not depend on
when the network answers.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The flow-extra check asks for docs to move with code. The #110 row now
says the outer conversation is refetched on the way back.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant