feat(esm_catalog): PR-A1b — core STAC infrastructure (flat layout)#1504
Merged
Conversation
- ESMItem(dict) and ESMCollection(dict) — STAC Item and Collection as plain-dict subclasses; JSON-serialisable with no extra dependencies - context.py — CollectionContext dataclass (breaks scan<->stac cycle) - uri.py — parse_uri / to_uri helpers for local and remote paths - registry.py — EXTENSION_URLS dict; custom schemas use esm-tools.github.io placeholder URLs until schemas land in configs/stac-extensions/ - Flat layout: no stac/ or extensions/ subdirectories - Core item properties only: variable, datetime, format, output_frequency, variables list (fields 1, 3, 5, 8, 10 from the metadata reference) - 12 tests, all passing Co-Authored-By: PavanSiligam <pavan.siligam@gmail.com> Co-Authored-By: Paul Gierz <pgierz@awi.de> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mandresm
changed the title
mandresm
changed the title
siligam
reviewed
Jun 29, 2026
siligam
reviewed
Jun 29, 2026
siligam
reviewed
Jun 29, 2026
…ck the functions Co-Authored-By: PavanSiligam <pavan.siligam@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…suggestions Co-Authored-By: PavanSiligam <pavan.siligam@gmail.com>
mandresm
commented
Jul 1, 2026
Co-Authored-By: PavanSiligam <pavan.siligam@gmail.com>Co-Authored-By: Paul Gierz <pgierz@awi.de>Co-Authored-By: Claude <noreply@anthropic.com>
mandresm
commented
Jul 1, 2026
mandresm
left a comment
mandresm
left a comment
Contributor
Author
There was a problem hiding this comment.
This is a self review with some changes needed for the code.
…n production Co-Authored-By: Claude <noreply@anthropic.com>
siligam
approved these changes
Jul 2, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
#bump #patch |
mandresm
added a commit
that referenced
this pull request
Jul 13, 2026
test(esm_catalog): additional coverage for the #1504 core
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @siligam and @pgierz,
I thought I'll give it a try to breaking down even more #1484 into smaller units that I could review. While on the process of doing that using claude-code, I also added my suggestions. This might be more time-efficient than just writing what I think and @siligam implementing it. I have included you both as co-authors. Since the code is rewritten by claude-code and myself this is the only way I found to keep you as contributors. Let me know if you are okay with this.
It would be great if one of you could review it.
This PR's scope is to keep add minimal core functionality to build the dictionary for STAC. These includes the following changes:
TODO