test(esm_catalog): additional coverage for the #1504 core#1508
Merged
Conversation
… properties) Co-Authored-By: Paul Gierz <pgierz@awi.de>
Co-Authored-By: Paul Gierz <pgierz@awi.de>
Co-Authored-By: Paul Gierz <pgierz@awi.de>
Co-Authored-By: Paul Gierz <pgierz@awi.de>
mandresm
approved these changes
Jul 13, 2026
mandresm
left a comment
mandresm
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks. I'll be merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra test coverage for #1504 we agreed on in Webex. Covers make_item edge cases (string/URI path inputs, naive-datetime normalization to UTC, open-ended ranges, the missing-datetime contract, item-id format and path-hash collision guard, media-type selection, variables/output_frequency filtering), collection extent behavior (first-bbox sentinel replacement, min/max merging, monotonic temporal growth), and production-context validation edges. Tests only, no source changes — 17 → 40 core tests.
One observation from probing (not enshrined in a test): an open-ended time range currently emits
start_datetimewithoutend_datetime, which the STAC spec recommends against. Happy to file it separately if you think it's worth tightening.