Skip to content

fix: optimization reducing memory allocations in MsgPackNullableDynamicSerializer #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esensar merged 1 commit into from
Mar 19, 2026
Merged

fix: optimization reducing memory allocations in MsgPackNullableDynamicSerializer #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 20 additions & 27 deletions ...onMain/kotlin/com.ensarsarajcic.kotlinx.serialization.msgpack/MsgPackDynamicSerializer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,33 +95,26 @@ open class MsgPackNullableDynamicSerializer(
encoder: Encoder,
value: Any?,
) {
if (value == null) encoder.encodeNull()
when (value!!::class) {
Boolean::class -> encoder.encodeBoolean(value as Boolean)
Byte::class -> encoder.encodeByte(value as Byte)
Short::class -> encoder.encodeShort(value as Short)
Int::class -> encoder.encodeInt(value as Int)
Long::class -> encoder.encodeLong(value as Long)
Float::class -> encoder.encodeFloat(value as Float)
Double::class -> encoder.encodeDouble(value as Double)
String::class -> encoder.encodeString(value as String)
ByteArray::class -> encoder.encodeSerializableValue(ByteArraySerializer(), value as ByteArray)
else -> {
when (value) {
is Map<*, *> -> MapSerializer(this, this).serialize(encoder, value as Map<Any?, Any?>)
is Array<*> -> ArraySerializer(this).serialize(encoder, value.map { it }.toTypedArray())
is List<*> -> ListSerializer(this).serialize(encoder, value.map { it })
is Map.Entry<*, *> -> MapEntrySerializer(this, this).serialize(encoder, value)
else ->
{
if (dynamicMsgPackExtensionSerializer.canSerialize(value)) {
dynamicMsgPackExtensionSerializer.serialize(encoder, value)
} else {
encoder.encodeSerializableValue(value::class.serializer() as KSerializer<Any>, value)
}
}
}
}
// Use ::class matching for numeric types instead of `is` checks because on Kotlin/JS
// all numbers are JavaScript doubles, and `is Byte` matches any integer in byte range
// regardless of the declared Kotlin type, causing incorrect encoding.
when {
value == null -> encoder.encodeNull()
value is Boolean -> encoder.encodeBoolean(value)
value is String -> encoder.encodeString(value)
value is ByteArray -> encoder.encodeSerializableValue(ByteArraySerializer(), value)
value is Map<*, *> -> MapSerializer(this, this).serialize(encoder, value as Map<Any?, Any?>)
value is Array<*> -> ArraySerializer(this).serialize(encoder, value as Array<Any?>)
value is List<*> -> ListSerializer(this).serialize(encoder, value)
value is Map.Entry<*, *> -> MapEntrySerializer(this, this).serialize(encoder, value)
value::class == Byte::class -> encoder.encodeByte(value as Byte)
value::class == Short::class -> encoder.encodeShort(value as Short)
value::class == Int::class -> encoder.encodeInt(value as Int)
value::class == Long::class -> encoder.encodeLong(value as Long)
value::class == Float::class -> encoder.encodeFloat(value as Float)
value::class == Double::class -> encoder.encodeDouble(value as Double)
dynamicMsgPackExtensionSerializer.canSerialize(value) -> dynamicMsgPackExtensionSerializer.serialize(encoder, value)
else -> encoder.encodeSerializableValue(value::class.serializer() as KSerializer<Any>, value)
}
}
}
Loading