fix: optimization reducing memory allocations in MsgPackNullableDynamicSerializer#111
Merged
Merged
Conversation
…icSerializer Replace `when (value!!::class)` with `when (value)` using `is` type checks in MsgPackNullableDynamicSerializer.serialize(). The previous implementation obtained a KClass via reflection on every call to match against class literals (e.g. Boolean::class), then performed redundant explicit casts (e.g. `value as Boolean`). Using `is` type checks instead compiles to simple instanceof checks with no reflection overhead or KClass allocations, and Kotlin smart casts eliminate the need for explicit casts. Also flattens the previously nested `when` block for collection types into a single-level `when` expression for readability.
Owner
|
Thanks, this makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
when (value!!::class)withwhen (value)usingistype checks in MsgPackNullableDynamicSerializer.serialize().The previous implementation obtained a KClass via reflection on every call to match against class literals (e.g. Boolean::class), then performed redundant explicit casts (e.g.
value as Boolean). Usingistype checks instead compiles to simple instanceof checks with no reflection overhead or KClass allocations, and Kotlin smart casts eliminate the need for explicit casts.Also flattens the previously nested
whenblock for collection types into a single-levelwhenexpression for readability.