Skip to content

ENH: Add an endpoint to fetch well headers from SMDA#426

Merged
GibranAlfa merged 2 commits into
equinor:mainfrom
GibranAlfa:fetch-well-data-from-SMDA
Jul 8, 2026
Merged

ENH: Add an endpoint to fetch well headers from SMDA#426
GibranAlfa merged 2 commits into
equinor:mainfrom
GibranAlfa:fetch-well-data-from-SMDA

Conversation

@GibranAlfa

@GibranAlfa GibranAlfa commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Resolves #342

  • Added POST /api/v1/smda/well_headers.
  • Added SmdaAPI.well_headers() using smda-api/wellheader-insight-headers/search.
  • Added SmdaWellHeader / SmdaWellHeadersResult models. Added some additional attributes in SmdaWellHeader that can be useful to identify the well. Documentation in docstrings are taken from SMDA directly.
  • Added service logic to fetch well headers by field identifier.
  • Added Drogon fallback data from RMS_WELLS.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@GibranAlfa GibranAlfa self-assigned this Jul 6, 2026
@GibranAlfa GibranAlfa added the enhancement New feature or request label Jul 6, 2026
@GibranAlfa
GibranAlfa requested a review from slangeveld July 6, 2026 12:13
@GibranAlfa
GibranAlfa force-pushed the fetch-well-data-from-SMDA branch 2 times, most recently from 7058c00 to 4ff4a86 Compare July 6, 2026 22:13
slangeveld
slangeveld approved these changes Jul 8, 2026
View reviewed changes

@slangeveld slangeveld left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well (😄) done! A few comments on the tests

Comment thread tests/test_interfaces/test_smda_api.py
Comment thread tests/test_v1/test_smda.py
@GibranAlfa
GibranAlfa force-pushed the fetch-well-data-from-SMDA branch from 53a826a to abcea27 Compare July 8, 2026 12:45
@GibranAlfa
GibranAlfa merged commit dbb5e7a into equinor:main Jul 8, 2026
7 checks passed
@GibranAlfa
GibranAlfa deleted the fetch-well-data-from-SMDA branch July 8, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slangeveld slangeveld slangeveld approved these changes

Assignees

@GibranAlfa GibranAlfa

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an endpoint to fetch well names from SMDA

2 participants

@GibranAlfa @slangeveld