Skip to content

fix(deploy): keep the secret-placeholder token out of spec prose #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elstonyth merged 1 commit into from
Jul 30, 2026
+3 −1
Merged

fix(deploy): keep the secret-placeholder token out of spec prose #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .do/backend.app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ envs:
value: __SECRET__PRICECHARTING_API_TOKEN__
# Required by Inventory > "Add from PC Collection". NOT a secret: it is the
# public 26-char PriceCharting user id (their docs publish an example one), so
# it is a plain value rather than a __SECRET__ placeholder. The token above
# it is a plain value rather than a redacted-secret placeholder (do-apply.ps1
# scans the WHOLE spec, comments included, so the literal placeholder token
# must never appear in prose here). The token above
# only AUTHENTICATES — it does NOT scope /api/offers to our account, so
# without this key PriceCharting answers with EVERY user's offers and the
# route refuses to run rather than import strangers' cards as our stock.
Expand Down