fix(deploy): keep the secret-placeholder token out of spec prose - #301
Conversation
#300 added a comment that spelled the redacted-secret placeholder token literally. do-apply.ps1's final guard greps the WHOLE spec text — comments included — for that token and aborts, so the prose alone was enough to block every backend deploy: pwsh scripts/do-apply.ps1 backend -Validate -> Unresolved secret placeholder remains - aborting Reworded, and the comment now says why the token must never appear in prose. `pwsh scripts/do-apply.ps1 backend -Validate` passes again ("Validation OK"), with exactly the ten real placeholders left in the file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideComment in the DigitalOcean backend app spec was reworded to avoid using the secret-placeholder token in prose, ensuring the deployment validation script no longer falsely detects an unresolved secret while preserving the actual secret placeholder and non-secret value configuration. Sequence diagram for backend spec validation avoiding secret placeholder in commentssequenceDiagram
actor Operator
participant do_apply_ps1 as do_apply.ps1
participant BackendSpec as backend.app.yaml
participant grep
Operator->>do_apply_ps1: backend -Validate
do_apply_ps1->>BackendSpec: load_spec
do_apply_ps1->>grep: search __SECRET__ tokens
grep-->>do_apply_ps1: [no placeholder token found in comments]
do_apply_ps1-->>Operator: Validation OK (no live change)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#300 broke
do-applywith a comment. The script's last guard greps the whole spec text — comments included — for the redacted-secret token, so writing it in prose was enough to abort every backend deploy:Reworded the comment, and it now states the constraint so the next person doesn't repeat it.
Verification
pwsh scripts/do-apply.ps1 backend -Validate→ "Validation OK (no live change)", i.e. DigitalOcean accepted the resolved spec.PRICECHARTING_SELLER_IDfrom chore(deploy): configure PRICECHARTING_SELLER_ID in prod #300 is untouched and still a plain value.Note: no prod change has been applied yet.
do-apply.ps1 backend(without-Validate) is what pushes the spec and redeploys, and that's a deliberate operator step.🤖 Generated with Claude Code
Summary by Sourcery
Clarify backend deployment spec comments to prevent the secret placeholder token from appearing in prose and breaking deploy validation.
Bug Fixes:
Deployment: