WindowTracker: ignore windows from our Wayland clients - #2490
Conversation
There was a problem hiding this comment.
I kinda don't love having yet another place where we can check whether something isn't a normal window.
Also in theory wayland clients may launch normal windows that would falsely be ignored here. And the other way round more windows can be ignored that aren't explicitly launched by a wayland client.
Can we maybe add this to ShellClientsManager.is_positioned_window (and maybe rename that to is_shell_window since it does more than just positioned windows for quite some time idk) similarly to how notifications are handled there?
Let me know what u think :)
8e2a2a1 to
85882be
Compare
|
@leolost2605 We currently use ManagedClient only to launch shell windows so I guess it's fine. By the way, gnome recently merged API to set window types directly, so we may want to remove ManagedClient and WaylandClient in OS 9 (https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4491) |
3 participants
Fixes #2079
Makes DaemonManager use ManagedClient instead of reimplementing it