Skip to content

Sync Datastream Categories with Policy Template Categories#19911

Open
JDKurma wants to merge 4 commits into
elastic:mainfrom
JDKurma:inline-ds-and-policy-cats
Open

Sync Datastream Categories with Policy Template Categories#19911
JDKurma wants to merge 4 commits into
elastic:mainfrom
JDKurma:inline-ds-and-policy-cats

Conversation

@JDKurma

@JDKurma JDKurma commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

Adds security to datastream categories to keep it in sync with existing policy template security category.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • ~I have verified that any added dashboard complies with Kibana's Dashboard good practices ~

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

#17523

Screenshots

@JDKurma JDKurma marked this pull request as ready for review July 1, 2026 13:16
@JDKurma JDKurma requested review from a team as code owners July 1, 2026 13:16
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Integration:tencent_cloud Tencent Cloud (Community supported) Integration:aws AWS Integration:gcp Google Cloud Platform Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 1, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment thread packages/aws/data_stream/transitgateway/manifest.yml
Comment thread packages/gcp/data_stream/loadbalancing_logs/manifest.yml
Comment thread packages/tencent_cloud/data_stream/clb/manifest.yml

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to be published, these will need version bumps (changelog entry and manifest version change). It's arguable as to whether this is a bug (missing expected category) or an enhancement (addition of a category). I suspect more likely bug. If you agree, the versions should bump patch, otherwise bump minor.

@JDKurma JDKurma requested a review from a team as a code owner July 2, 2026 14:50
Comment thread packages/aws/changelog.yml Outdated
Comment thread packages/gcp/changelog.yml Outdated
Comment thread packages/tencent_cloud/changelog.yml Outdated
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

TL;DR

All three failed Buildkite jobs are failing package lint because the new top changelog entries use type: bug, which is not an allowed changelog type. Change those entries to type: bugfix.

Remediation

  • Update packages/aws/changelog.yml, packages/gcp/changelog.yml, and packages/tencent_cloud/changelog.yml so the new changelog entry uses type: bugfix instead of type: bug.
  • Re-run the affected package checks, for example the same Buildkite steps or elastic-package check for packages/aws, packages/gcp, and packages/tencent_cloud.
Investigation details

Root Cause

The PR adds new changelog entries with an invalid changelog type in each affected package. elastic-package accepts only breaking-change, bugfix, or enhancement, and the newly added entries use bug instead:

  • packages/aws/changelog.yml:5type: bug
  • packages/gcp/changelog.yml:5type: bug
  • packages/tencent_cloud/changelog.yml:5type: bug

Evidence

packages/aws/changelog.yml is invalid: field 0.changes.0.type: 0.changes.0.type must be one of the following: "breaking-change", "bugfix", "enhancement"
packages/gcp/changelog.yml is invalid: field 0.changes.0.type: 0.changes.0.type must be one of the following: "breaking-change", "bugfix", "enhancement"
packages/tencent_cloud/changelog.yml is invalid: field 0.changes.0.type: 0.changes.0.type must be one of the following: "breaking-change", "bugfix", "enhancement"

Verification

Not run locally: elastic-package is not installed in this workspace. The Buildkite logs already show schema validation failing before package tests proceed.

Follow-up

The same invalid changelog type is also already identified by the automated review comment; fixing those comments should address these Buildkite failures.


What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@vera-review-bot

Copy link
Copy Markdown

No issues across the latest commits cac9797, 621d7e8.

Review summary

Issues found across earlier commits 73d2fc0 — 3 high
  • 🟠 Changelog entry uses invalid type 'bug'; the changelog schema only accepts enhancement, bugfix, or breaking-change. Change type to 'bugfix' so elastic-package validation passes. (link) (Unresolved)
  • 🟠 Changelog entry uses invalid type 'bug'; the changelog schema only accepts enhancement, bugfix, or breaking-change. Change type to 'bugfix' so elastic-package validation passes. (link) (Unresolved)
  • 🟠 Changelog entry uses invalid type 'bug'; the changelog schema only accepts enhancement, bugfix, or breaking-change. Change type to 'bugfix' so elastic-package validation passes. (link) (Unresolved)
Issues found across earlier commits 06f2b3a — 3 high
  • 🟠 AWS package manifests are modified but the PR does not bump packages/aws version or add a changelog.yml entry; bump the version and add a changelog entry so the change ships. (link) (Resolved)
  • 🟠 GCP package manifests are modified but the PR does not bump packages/gcp version or add a changelog.yml entry; bump the version and add a changelog entry so the change ships. (link) (Resolved)
  • 🟠 Tencent Cloud package manifests are modified but the PR does not bump packages/tencent_cloud version or add a changelog.yml entry; bump the version and add a changelog entry so the change ships. (link) (Resolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

✅ All changelog entries have the correct PR link.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Integration:gcp Google Cloud Platform Integration:tencent_cloud Tencent Cloud (Community supported) Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants