Repository navigation
[9.4] chore(cli): stop creating connector secrets for native connectors (#4579) - #4581
Merged
Merged
Conversation
) ## Closes #2990 Follow-up to #4524. Since 9.0 (#2989) the framework never reads connector secrets, but `connectors connector create --native` still stored the connector API key in a connector secret and wrote its id to `api_key_secret_id`. Nothing consumes that secret. Changes: - CLI no longer creates a connector secret; `api_key_secret_id` is written as `null` - Remove `ESManagementClient.create_connector_secret()` (CLI was the only caller) and its test - Remove `test_get_index_or_alias`, a copy of the secret test that never called `get_index_or_alias` (covered by `test_extract_index_or_alias_*`) - `CONNECTOR_PROTOCOL.md`: note `api_key_secret_id` is not read by the framework since 9.0 Deliberately kept: - `native_connector_api_keys` in `BaseDataSource.features()`: part of the ES `ConnectorFeatures` schema; removing it would make native connector docs be rewritten on every scheduler poll, because the key sets would never match - `api_key_secret_id` field: still part of the ES Connector API and written by Kibana Not for 8.19: 8.19 still reads connector secrets during native syncs. ## Checklists #### Pre-Review Checklist - [x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check `config.yml.example`) - [x] this PR has a meaningful title - [x] this PR links to all relevant github issues that it fixes or partially addresses - [x] Covered the changes with automated tests - [x] Tested the changes locally (`make clean install autoformat lint test`) - [x] Added a label for each target release version (example: `v7.13.2`, `v7.14.0`, `v8.0.0`) ## Release Note The `connectors connector create --native` CLI command no longer stores the connector API key in a connector secret.
entsearchmachine
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.4: