Repository navigation
chore(cli): stop creating connector secrets for native connectors - #4579
Merged
Merged
Conversation
erikcurrin-elastic
approved these changes
Oct 7, 2026
Jan-Kazlouski-elastic
enabled auto-merge (squash)
October 7, 2026 14:16
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2990
Follow-up to #4524. Since 9.0 (#2989) the framework never reads connector secrets, but
connectors connector create --nativestill stored the connector API key in a connector secret and wrote its id toapi_key_secret_id. Nothing consumes that secret.Changes:
api_key_secret_idis written asnullESManagementClient.create_connector_secret()(CLI was the only caller) and its testtest_get_index_or_alias, a copy of the secret test that never calledget_index_or_alias(covered bytest_extract_index_or_alias_*)CONNECTOR_PROTOCOL.md: noteapi_key_secret_idis not read by the framework since 9.0Deliberately kept:
native_connector_api_keysinBaseDataSource.features(): part of the ESConnectorFeaturesschema; removing it would make native connector docs be rewritten on every scheduler poll, because the key sets would never matchapi_key_secret_idfield: still part of the ES Connector API and written by KibanaNot for 8.19: 8.19 still reads connector secrets during native syncs.
Checklists
Pre-Review Checklist
config.yml.example)make clean install autoformat lint test)v7.13.2,v7.14.0,v8.0.0)Release Note
The
connectors connector create --nativeCLI command no longer stores the connector API key in a connector secret.