Skip to content

chore(cli): stop creating connector secrets for native connectors - #4579

Merged
Jan-Kazlouski-elastic merged 1 commit into
mainfrom
connectors-issue-2990
Oct 7, 2026
Merged

Jan-Kazlouski-elastic merged 1 commit into
mainfrom
connectors-issue-2990

Conversation

@Jan-Kazlouski-elastic

Copy link
Copy Markdown
Contributor

Closes #2990

Follow-up to #4524. Since 9.0 (#2989) the framework never reads connector secrets, but connectors connector create --native still stored the connector API key in a connector secret and wrote its id to api_key_secret_id. Nothing consumes that secret.

Changes:

  • CLI no longer creates a connector secret; api_key_secret_id is written as null
  • Remove ESManagementClient.create_connector_secret() (CLI was the only caller) and its test
  • Remove test_get_index_or_alias, a copy of the secret test that never called get_index_or_alias (covered by test_extract_index_or_alias_*)
  • CONNECTOR_PROTOCOL.md: note api_key_secret_id is not read by the framework since 9.0

Deliberately kept:

  • native_connector_api_keys in BaseDataSource.features(): part of the ES ConnectorFeatures schema; removing it would make native connector docs be rewritten on every scheduler poll, because the key sets would never match
  • api_key_secret_id field: still part of the ES Connector API and written by Kibana

Not for 8.19: 8.19 still reads connector secrets during native syncs.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • Covered the changes with automated tests
  • Tested the changes locally (make clean install autoformat lint test)
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Release Note

The connectors connector create --native CLI command no longer stores the connector API key in a connector secret.

@Jan-Kazlouski-elastic
Jan-Kazlouski-elastic enabled auto-merge (squash) October 7, 2026 14:16
@Jan-Kazlouski-elastic
Jan-Kazlouski-elastic merged commit 5c6ecb1 into main Oct 7, 2026
7 checks passed
@Jan-Kazlouski-elastic
Jan-Kazlouski-elastic deleted the connectors-issue-2990 branch October 7, 2026 14:29
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

💚 Backport PR(s) successfully created

Status Branch Result
✅ 9.5 #4580
✅ 9.4 #4581

The backport PRs will be merged automatically after passing CI.

Jan-Kazlouski-elastic added a commit that referenced this pull request Oct 7, 2026
…rs (#4579) (#4581)

Backports the following commits to 9.4:
- chore(cli): stop creating connector secrets for native connectors
(#4579)

Co-authored-by: Jan-Kazlouski-elastic <jan.kazlouski@elastic.co>
Jan-Kazlouski-elastic added a commit that referenced this pull request Oct 8, 2026
…rs (#4579) (#4580)

Backports the following commits to 9.5:
- chore(cli): stop creating connector secrets for native connectors
(#4579)

Co-authored-by: Jan-Kazlouski-elastic <jan.kazlouski@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Framework] Clean up native connector secrets code

2 participants