Fix highlighting of parameterized module instantiations (0.14.2)#281
Merged
joecrop merged 1 commit intoJun 3, 2026
Merged
Conversation
A `class-instance-parameters` rule (added during the syntax-highlighting overhaul) was included before `module-parameters` in the top-level patterns. Both rules' `begin` match `Name #(` at the same position, so the earlier one won for module instantiations too — applying class-flavored scopes without the `#module-binding`/`#port-net-parameter` includes. The result: for `mod #(...) u_mod (...)` the module name, instance name and port connections lost their proper highlighting (the parameterless form was unaffected). Reorder so `#module-parameters` is matched before `#class-instance-parameters`, restoring the pre-overhaul behavior: module name -> entity.name.type.module, instance -> variable.other.module, ports -> support.function.port. Bumps to 0.14.2 and adds verilog-examples/param_instantiation.sv. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
class-instance-parametersrule (added during the syntax-highlighting overhaul) was included beforemodule-parametersin the top-level patterns. Both rules'beginmatchName #(at the same position, so the earlier one won for module instantiations too — applying class-flavored scopes without the#module-binding/#port-net-parameterincludes. The result: formod #(...) u_mod (...)the module name, instance name and port connections lost their proper highlighting (the parameterless form was unaffected).Reorder so
#module-parametersis matched before#class-instance-parameters, restoring the pre-overhaul behavior: module name -> entity.name.type.module, instance -> variable.other.module, ports -> support.function.port.Bumps to 0.14.2 and adds verilog-examples/param_instantiation.sv.