Skip to content

CBAM KIT 1.0 - #1382

Closed
wehrstedt-jan wants to merge 1 commit into
eclipse-tractusx:mainfrom
Jarosch-Mitko:main
Closed

CBAM KIT 1.0#1382
wehrstedt-jan wants to merge 1 commit into
eclipse-tractusx:mainfrom
Jarosch-Mitko:main

Conversation

@wehrstedt-jan

@wehrstedt-jan wehrstedt-jan commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Description

This PR covers the first version of the CBAM KIT, adressing the Catena-X solution for the Carbon border adjustment mechanism. It contains a descrition of the CBAM process and the initial data model for the exchange of data between the importer/declarant and supplier.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer

Copy link
Copy Markdown
Member

Please fix the issues before the review, thx

image

@stephanbcbauer
stephanbcbauer requested a review from a team November 18, 2025 10:50
@stephanbcbauer stephanbcbauer added the KIT KIT related content, mapped to TRactus-X releases label Nov 19, 2025
@stephanbcbauer stephanbcbauer added this to the 25.12 milestone Nov 19, 2025
@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

@stephanbcbauer : issues should be fixed

@stephanbcbauer

Copy link
Copy Markdown
Member

@eclipse-tractusx/automotive-tractusx-committers i am not available for the next days, please support here to merge the changes. They are relevant for Release 25.12 Thx

@matbmoser

Copy link
Copy Markdown
Contributor

Please add this KIT to the master data

@stephanbcbauer stephanbcbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution:

  • Could you please add the *.license files for the svg
  • Please use kebapb-case for the svg names
  • PLease add the KIT to masterdata if not already done
  • res.text can be deleted?
  • only adaption-view seems to have content. What about the other files?

Comment thread docs-kits/kits/cbam-kit/res/res.txt Outdated
@@ -0,0 +1 @@
1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file could be deleted?

@github-project-automation github-project-automation Bot moved this from Inbox to Todo in Tractus-X Webpage Nov 27, 2025

@matbmoser matbmoser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure you include in the kit master data the information about this kit!

https://eclipse-tractusx.github.io/docs/release/trg-10/trg-10-01#master-data

@matbmoser

Copy link
Copy Markdown
Contributor

Also please add the license for your images :) https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07

@matbmoser

matbmoser commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

we also need a cool logo @Grand-Thibault

@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

please make sure you include in the kit master data the information about this kit!

https://eclipse-tractusx.github.io/docs/release/trg-10/trg-10-01#master-data

we are waiting fot the logo

@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

we also need a cool logo @Grand-Thibault

@Grand-Thibault is already working on it

@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution:

  • Could you please add the *.license files for the svg
  • Please use kebapb-case for the svg names
  • PLease add the KIT to masterdata if not already done
  • res.text can be deleted?
  • only adaption-view seems to have content. What about the other files?

1,2,4,5 done; 3 waiting for logo

@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

Also please add the license for your images :) https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07

done in update

@stephanbcbauer

Copy link
Copy Markdown
Member

Good morning, after review/discussion with @ther3sa and @jSchuetz88

@matbmoser what about the icon/logo. Do you provide a new one here? What about the master data file and the state of the KIT?

@wehrstedt-jan , @martinaprox This PR needs to be merged today/tomorrow because we need to execute the versioning plug-in tomorrow, to prepare the release 25.12 To provide the state for the KIT, please merge main into your branch.

For more details about the new structure, please ask @matbmoser

@martinaprox martinaprox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done together with Johannes Wunderlich and Martin Jarosch-Mitko and approved for release.

@stephanbcbauer

Copy link
Copy Markdown
Member

After discussion in standardization hour ⇾ KIT will be provided as soon as possible. Expected milestone would be 26.03.

@stephanbcbauer stephanbcbauer modified the milestones: 25.12, 26.03 Dec 1, 2025
@wehrstedt-jan

Copy link
Copy Markdown
Contributor Author

will be shifted to 2603

Pull Request will be reopened as asoon logo is available

@github-project-automation github-project-automation Bot moved this from Todo to Done in Tractus-X Webpage Dec 5, 2025
@matbmoser matbmoser reopened this Jan 26, 2026
@matbmoser

Copy link
Copy Markdown
Contributor

Obviously, some of the pictures are obsolete now. I recommend to remove them, as they are of no value, namely cbam-architecture-alternative.drawio.svg and cbam-architecture.svg. They are not referenced in any .md file. Please remove them prior to merging the PR

I agree on removing the old images.

@matbmoser matbmoser Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgblaumeiser why to remove the dataplane?

This is how it is working now. If it changes in the future, it shall be updated in the future.

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not complain on that picture :-). It might change, but that is future

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did saw it with missing data then,.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored the original architecture picture as shown above which is now described in the development view.

@matbmoser

Copy link
Copy Markdown
Contributor

I am still having this conflicts
image

@matbmoser matbmoser added stale Items without activities blocked PR is blocked because of a reason (specify with another label), and can't be merged question Further information is requested and removed stale Items without activities labels Mar 4, 2026
@Jarosch-Mitko

Copy link
Copy Markdown
Contributor

I've been trying to delete the unused images since Monday. However, the delete command isn't working for me.

@matbmoser matbmoser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I have done the logo I need to add the copyright from my company.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did saw it with missing data then,.

Comment thread data/kitsData.js Outdated
@matbmoser

Copy link
Copy Markdown
Contributor

I've been trying to delete the unused images since Monday. However, the delete command isn't working for me.

lol

@matbmoser

matbmoser commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

@Jarosch-Mitko would it be fine to add it like it was before the diagram?

right now I see it like this:
image

and should be like this:

image

so we are also concise with what is happening and the interactions between systems. I commented to Lars that if we also abstract too much it is then not very clear what interacts with what.

@matbmoser matbmoser moved this from Todo to In Progress in KIT Office Hour Mar 4, 2026

@stanfaldin stanfaldin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@matbmoser

Copy link
Copy Markdown
Contributor

ok there was a problem here:

image

I have change it to this (Adding a blank background)

image

@matbmoser

matbmoser commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

I need to override your branch @Jarosch-Mitko I have stored a backup so we dont lose your changes.

cbam-kit.zip

Working on your main is not a good option, please create a separated branch next time, this confuses GitHub and creates a "fork" which is different to the latest version, not allowing me to merge this PR. So in the end everything got invalid when I started to resolve conflicts. So at the end was more easy to close and sync you branch fork with our main, and create a clean PR with your latest changes.

@matbmoser matbmoser closed this Mar 8, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Tractus-X Webpage Mar 8, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in KIT Office Hour Mar 8, 2026
@matbmoser matbmoser reopened this Mar 8, 2026
@matbmoser

Copy link
Copy Markdown
Contributor

Dont worry I am just fixing your branch.

@matbmoser matbmoser closed this Mar 8, 2026
@matbmoser matbmoser added the invalid This doesn't seem right label Mar 8, 2026
@matbmoser

Copy link
Copy Markdown
Contributor

This PR was invalid, since the commit history was destroyed at some point, and I could not fix it.

Have created a clean one here: #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PR is blocked because of a reason (specify with another label), and can't be merged invalid This doesn't seem right KIT KIT related content, mapped to TRactus-X releases question Further information is requested

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

10 participants