Pr/wehrstedt Jan/1382: CBAM KIT commit history fixed. - #1495
Conversation
Mission and Vision initially added
add image
data model added
Update linting
logo is under development
blank lines removed
corrected hyperlink format
res.txt deleted
ada pt text to new image names
There was a problem hiding this comment.
Hey @matbmoser! Every protocol is used for communication. DCP covers issuance, and presentation of VCs. Connector to Connector communication happens only via DSP. Please remove DCP, it's not correct here.
… and development view
|
Included changes from @wehrstedt-jan |
|
@matbmoser cannot approve it , because of the failing website build. Please check the mdx linter. I think its only one file |
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial CBAM KIT content and wires it into the site’s navigation/kit registry (as a Sandbox KIT under the /docs-kits/next/ route prefix), replacing a previously broken PR attempt.
Changes:
- Add CBAM KIT documentation (adoption view, development view, changelog) plus diagram resources and their license metadata.
- Register CBAM KIT in KIT master data (
kitsData.js) including logo, maturity, and routing. - Expose CBAM KIT in navigation (generated KIT nav items + docs sidebar), and extend Eco Pass sidebar with a Documentation section.
Reviewed changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/generated/kitNavItems.js | Adds CBAM KIT entry and route to generated nav items. |
| static/img/kits/cbam/cbam-kit-raw-logo.svg.license | Adds license metadata for CBAM logo. |
| sidebarsDocsKits.js | Adds CBAM KIT to docs sidebar; adds Eco Pass “Documentation” category. |
| docs-kits/kits/cbam-kit/resources/cbam-process.drawio.svg.license | Adds license metadata for CBAM process diagram. |
| docs-kits/kits/cbam-kit/resources/cbam-process.drawio.svg | Adds CBAM process diagram asset. |
| docs-kits/kits/cbam-kit/resources/Architecture_simply.drawio.svg.license | Adds license metadata for CBAM architecture diagram. |
| docs-kits/kits/cbam-kit/development-view/development-view.md | Adds CBAM KIT development view (architecture + detailed data model docs + samples). |
| docs-kits/kits/cbam-kit/changelog.md | Adds CBAM KIT changelog page. |
| docs-kits/kits/cbam-kit/adoption-view/adoption-view.md | Adds CBAM KIT adoption view documentation. |
| data/kitsData.js | Registers CBAM KIT in KIT master data (logo, maturity, route, metadata). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marcelruland
left a comment
marcelruland
left a comment
There was a problem hiding this comment.
Minor comments requiring clarification. No major changes. Once these are addressed I'm happy to approve.
|
@matbmoser fixed the markdown (mdx) linting issues with this commit. There are still (new) some suggestions made by @marcelruland (thx) |
|
@johannes-wunderlich @wehrstedt-jan @Jarosch-Mitko please take a look and answer on marcels comments. @marcelruland thanks for the review. We have not much time left, so I hope that are your last remarks, if any change is needed extra to that it can be done in a separate PR in the future (since the KIT is only on its initial contribution). However we appreciate any review, specially if it increases the quality of the KIT. As I understood here there are no blockers, and the KIT could be merge as soon as the comments are resolved. |
There was a problem hiding this comment.
it was removed already, please take a look again.
Co-authored-by: Mathias Moser <mathias.moser@catena-x.net>
|
Ok review completed, implemented changes from @marcelruland and proposal from @johannes-wunderlich. Now we should be good to go. Any other changes please introduce into other pull requests. thank you for this so detailed review. most of the KITs have not such a quality review as this one! Great Job everyone! |
Sound good -> will push the button :) |
Description
Original PR was broken: #1382
So I needed to fix it.
Original description:
This PR covers the first version of the CBAM KIT, adressing the Catena-X solution for the Carbon border adjustment mechanism. It contains a descrition of the CBAM process and the initial data model for the exchange of data between the importer/declarant and supplier.
Authors: @wehrstedt-jan and @Jarosch-Mitko
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: