Skip to content

fix: remove duplicate String format #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndr-brt merged 1 commit into from
Jul 30, 2026
Merged

fix: remove duplicate String format #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...n/java/org/eclipse/edc/identityhub/spi/verifiablecredentials/model/CredentialProfile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*
* Contributors:
* Metaform Systems, Inc. - initial API and implementation
* Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. - fix duplicate String format bug
*
*/

Expand Down Expand Up @@ -59,7 +60,7 @@ public static ServiceResult<CredentialFormat> formatForProfile(String profile) {
try {
return success(CredentialFormat.valueOf(profile));
} catch (IllegalArgumentException e) {
return ServiceResult.badRequest(String.format("Invalid format: '%s', expected one of '%s, '%s' or %s".formatted(profile, DCP_PROFILE_VC11, DCP_PROFILE_VC20, VALID_CREDENTIAL_FORMATS)));
return ServiceResult.badRequest("Invalid format: '%s', expected one of '%s, '%s' or %s".formatted(profile, DCP_PROFILE_VC11, DCP_PROFILE_VC20, VALID_CREDENTIAL_FORMATS));
}
}
}
Expand All @@ -75,7 +76,7 @@ public static ServiceResult<String> profileForFormat(CredentialFormat format) {
case VC1_0_JWT -> success(DCP_PROFILE_VC11);
case VC2_0_JOSE -> success(DCP_PROFILE_VC20);
default ->
ServiceResult.badRequest(String.format("Unsupported format: '%s', expected one of '%s, '%s' or %s".formatted(format, DCP_PROFILE_VC11, DCP_PROFILE_VC20, VALID_CREDENTIAL_FORMATS)));
ServiceResult.badRequest("Unsupported format: '%s', expected one of '%s, '%s' or %s".formatted(format, DCP_PROFILE_VC11, DCP_PROFILE_VC20, VALID_CREDENTIAL_FORMATS));
};
}
}
Loading