fix: remove duplicate String format - #1048
Merged
ndr-brt merged 1 commit intoJul 30, 2026
Merged
Conversation
Contributor
|
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contributors manual, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion. |
paullatzelsperger
approved these changes
Jul 27, 2026
Member
|
@mhellmeier the change per se is fine, I approved it, but you seem to have compile errors. maybe rebasing onto |
ndr-brt
approved these changes
Jul 27, 2026
ndr-brt
left a comment
ndr-brt
left a comment
Member
There was a problem hiding this comment.
you can rebase against main to get green checks
mhellmeier
force-pushed
the
fix/duplicate-string-format
branch
from
July 30, 2026 07:04
5281178 to
b6a9d78
Compare
Contributor
Author
|
Rebased against main, ready to be merged @ndr-brt & @paullatzelsperger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove duplicate
String.formatinCredentialProfile.java.Why it does that
To prevent an externally controlled format string due to duplicate parsing (e.g., when using a
%). The issue was raised as a high security issue by CodeQL.Further notes
./.
Who will sponsor this feature?
./.
Linked Issue(s)
Closes #1044