feat(harmonia): unify page/record title styling across all generated views + shell - #6361
Merged
Conversation
…views + shell
Every page title now uses one caption style - text-2xl font-semibold tracking-tight:
- Record captions (document header, manage create/edit form, form-builder title):
were an uppercased font-normal label; now semibold and NOT uppercased ('Sales
Invoice', not 'SALES INVOICE'). The document number keeps font-bold so it stays
heavier than the caption ('Sales Invoice SI-0000001').
- Browse titles (list, manage list, master-detail, report chart/table, report-file):
x-h-toolbar-title kept (truncation) with the caption classes added.
- Built-in shell sections: the Inbox title adopts the caption style, and Documents
gains a 'Documents' caption alongside its path breadcrumb (root = Home).
Secondary headers left as-is by design: the master-detail 'Entity #id' sub-panel
titles, the document items-panel header, card ('Details') and dialog titles.
Verified live: regenerated kf-mod-sales-invoices - the list, document caption/number,
and the shared Inbox/Documents shell all render the unified caption.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
delchev
added a commit
that referenced
this pull request
Jul 22, 2026
…6372) #6361 unified the form caption to the document-title style and dropped the force-uppercase (.toUpperCase()), matching the non-uppercased document layout - but this UI assertion still expected the old all-caps 'ORDERS' and was left red on master. Assert the resolved human label 'Orders' instead; the test's intent (the generator derives a real label, not the raw ${ENTITYLABEL} placeholder) is unchanged. Only source assertion affected. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
delchev
added a commit
that referenced
this pull request
Jul 22, 2026
…re (#6388) The test asserted exactly one <span> containing 'Orders' as the create-form caption. Since the fixture entity is named 'Orders', its derived entityLabel (the form caption) equals its menuLabel (the list toolbar title), and #6361 unified both to caption <span>s - so the label legitimately renders in two places and the ExistsByTypeAndContainsText finder (which rejects >1 match) fails with 'Found [2] ... expected at most one'. (#6372 surfaced it by lowercasing the form caption to match the list title's 'Orders'.) The assertion's real intent is that the generator DERIVED the label rather than leaking the literal ${ENTITYLABEL}; assert that placeholder is ABSENT instead - count-immune, and the form rendering + label resolution stay proven by the Country/City depends-on assertions that follow. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies every page/record title in the generated Harmonia UI (and the built-in shell sections) to one caption style:
text-2xl font-semibold tracking-tight.Changes
font-normallabel. They're now semibold and not uppercased ("Sales Invoice", not "SALES INVOICE"). The document number keepsfont-boldso it stays heavier than the caption → "Sales Invoice SI-0000001".x-h-toolbar-titleis kept (truncation in the toolbar) with the caption classes added.application-coreshell.Secondary headers are left as-is by design: the master-detail
Entity #idsub-panel titles, the document items-panel header, and the card ("Details") / dialog titles.Verification (live)
Rebuilt the jar and regenerated
kf-mod-sales-invoices: the browse list, the document caption + bold number, and the shared Inbox/Documents shell all render the unified caption. No Java touched (template + shell HTML only).Follow-up to the merged #6355 (which humanized the labels + task-form Details layout).
🤖 Generated with Claude Code