test(ui): fix DependsOnHarmoniaIT caption assertion (ORDERS -> Orders) broken by #6361 - #6372
Merged
Merged
Conversation
#6361 unified the form caption to the document-title style and dropped the force-uppercase (.toUpperCase()), matching the non-uppercased document layout - but this UI assertion still expected the old all-caps 'ORDERS' and was left red on master. Assert the resolved human label 'Orders' instead; the test's intent (the generator derives a real label, not the raw ${ENTITYLABEL} placeholder) is unchanged. Only source assertion affected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
delchev
added a commit
that referenced
this pull request
Jul 22, 2026
…re (#6388) The test asserted exactly one <span> containing 'Orders' as the create-form caption. Since the fixture entity is named 'Orders', its derived entityLabel (the form caption) equals its menuLabel (the list toolbar title), and #6361 unified both to caption <span>s - so the label legitimately renders in two places and the ExistsByTypeAndContainsText finder (which rejects >1 match) fails with 'Found [2] ... expected at most one'. (#6372 surfaced it by lowercasing the form caption to match the list title's 'Orders'.) The assertion's real intent is that the generator DERIVED the label rather than leaking the literal ${ENTITYLABEL}; assert that placeholder is ABSENT instead - count-immune, and the form rendering + label resolution stay proven by the Country/City depends-on assertions that follow. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
masteris red — theBuildworkflow's integration-tests (h2 and postgresql) fail on:Cause
#6361 (unify page/record title styling) rewrote the manage form-view caption from
to
dropping the force-uppercase so the form caption matches the (non-uppercased) document-title style it was unified with. The rendered DOM text is now
Orders, butDependsOnHarmoniaTestProjectstill asserted the old all-capsORDERS(Selenide reads DOM text, not CSS), and the test was not updated in #6361. It is the only source assertion affected (verified by grep overtests/**).Fix
Assert the resolved human label
Orders. The test's documented intent — that the generator derives a real label rather than leaving the raw${ENTITYLABEL}placeholder — is unchanged;Ordersstill proves resolution. Also refreshed the now-stale "(uppercased)" comment.Verification
tests/tests-integrationstest-compiles. The full Selenide UI suite (~2h) was not re-run locally; the change is a deterministic string-literal correction matching the caption the current template emits (confirmed against theform-viewanddocument-viewtemplates onmaster).