Skip to content

fix(http bridge): let undici own Content-Length for buffered request bodies #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epslkslsksndnsjs-lab wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −13
Open

fix(http bridge): let undici own Content-Length for buffered request bodies #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions host/src/qemu/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,18 +731,18 @@ export async function handleHttpDataWithWriter(
url: baseRequest.url,
headers: {
...baseRequest.headers,
"content-length": body.length.toString(),
},
body: body.length > 0 ? body : null,
};

request.headers = { ...request.headers };
delete request.headers["transfer-encoding"];
if (request.body) {
request.headers["content-length"] = request.body.length.toString();
} else {
delete request.headers["content-length"];
}
request.headers = { ...request.headers };
delete request.headers["transfer-encoding"];
// Let undici compute Content-Length from the buffered body. Node >= 24.17's
// undici rejects a manually supplied Content-Length for a buffered body
// ("invalid content-length header"), which surfaced as a 502 for buffered
// request bodies (issue #134). undici sets an accurate Content-Length
// automatically for buffered/string bodies.
delete request.headers["content-length"];

httpSession.processing = true;
let releaseHttpConcurrency: (() => void) | null = null;
Expand Down Expand Up @@ -1015,11 +1015,12 @@ export async function handleHttpDataWithWriter(
// Normalize framing headers for fetch.
request.headers = { ...request.headers };
delete request.headers["transfer-encoding"];
if (request.body) {
request.headers["content-length"] = request.body.length.toString();
} else {
delete request.headers["content-length"];
}
// Let undici compute Content-Length from the buffered body. Node >= 24.17's
// undici rejects a manually supplied Content-Length for a buffered body
// ("invalid content-length header"), which surfaced as a 502 for buffered
// request bodies (issue #134). undici sets an accurate Content-Length
// automatically for buffered/string bodies.
delete request.headers["content-length"];

httpSession.processing = true;
let releaseHttpConcurrency: (() => void) | null = null;
Expand Down