fix(http bridge): let undici own Content-Length for buffered request bodies - #141
Open
epslkslsksndnsjs-lab wants to merge 1 commit into
Conversation
…bodies Resolves earendil-works#134. On Node.js >= 24.17, undici rejects a manually supplied Content-Length header for a buffered request body (invalid content-length header), which the bridge surfaced as a 502 for buffered request bodies. The bridge no longer sets Content-Length manually on the buffered request paths (content-length-complete and chunked-complete); undici computes an accurate Content-Length from the buffered body automatically. The parsed Content-Length is still normalized during request parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #134.
On Node.js >= 24.17, undici rejects a manually supplied
Content-Lengthheader for a buffered request body (invalid content-length header). The bridge forwards buffered request bodies with a manually setContent-Length, so undici throws and the bridge returns a 502 for buffered request bodies.Changes in
host/src/qemu/http.ts:Content-Lengthmanually; undici computes an accurateContent-Lengthfrom the buffered body automatically.Content-Lengthis still normalized during request parsing.Note: I could not run the full gondolin test suite here (needs pnpm + QEMU). The change is minimal and scoped to the two buffered-body completion paths; please verify on CI across the supported Node versions (esp. >= 24.17).