Repository navigation
feat(settings): let the content area separate itself from the title bar - #702
Merged
Merged
Conversation
The title bar is painted with the window's own background colour, so with nothing between them it is hard to tell where it ends - and where to grab it. The appearance section gains a switch that draws a border along the top of the content. It is only offered, and only drawn, while the title bar really is painted like the content: once it follows the Windows theme it has a colour of its own and the border would be decoration. Gating what is drawn as well as what is offered means a preference saved earlier cannot stay active, invisibly, behind a switch that is no longer there. The choice is remembered in the webview's storage rather than config.toml, because it is presentation only and that file is the daemon's too. It is read synchronously, so the first paint already has it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title bar is painted with the window's own background colour, so with nothing between
them it is hard to tell where it ends - and where to grab it. The appearance section gains
a switch that draws a border along the top of the content.
It is only offered, and only drawn, while the title bar really is painted like the
content: once it follows the Windows theme it has a colour of its own and the border would
be decoration. Gating what is drawn as well as what is offered means a preference saved
earlier cannot stay active, invisibly, behind a switch that is no longer there.
The choice is remembered in the webview's storage rather than config.toml, because it is
presentation only and that file is the daemon's too. It is read synchronously, so the
first paint already has it.