Skip to content

Feature/hatch patterns #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dubstar-04 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/hatch patterns #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ad01a7
Update io.github.dubstar_04.design.metainfo.xml
dubstar-04 May 23, 2026
ae75629
Handle readonly properties
dubstar-04 May 23, 2026
9cb63b2
Use the correct property for boolean state
dubstar-04 May 23, 2026
a3df359
Update Design-Core
dubstar-04 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions data/io.github.dubstar_04.design.metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@
<li>Add Preview for Extend Command (EX)</li>
<li>Improve character spacing for ArcText Command (ArcText)</li>
<li>Improve mouse wheel zoom precision</li>
<li>Fix handling of Insert entities with no block defined</li>
<li>Fix Zoom All with invalid scale value</li>
<li>Add support for user-defined hatch patterns</li>
Comment on lines +73 to +75
</ul>
</description>
</release>
Expand Down
2 changes: 1 addition & 1 deletion src/Design-Core
Open in desktop
Submodule Design-Core updated 13 files
+182 −12 core/entities/hatch.js
+6 −1 core/entities/insert.js
+2 −0 core/lib/canvas.js
+2 −1 core/properties/entityProperties.js
+12 −0 core/properties/flags.js
+7 −2 core/properties/property.js
+15 −0 core/properties/propertyManager.js
+2 −0 core/tables/block.js
+2 −0 cspell.json
+323 −0 test/entities/hatch.test.js
+73 −0 test/lib/clipboard.test.js
+24 −0 test/properties/flags.test.js
+71 −0 test/properties/propertyManager.test.js
11 changes: 9 additions & 2 deletions src/Design/Properties/propertiesWindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ export const PropertiesWindow = GObject.registerClass({
onValueChanged(property, value) {
const selectedType = this.getFilterValue();
DesignCore.PropertyManager.setEntityProperties(property, value, selectedType);
// Rebuild the widget list so readOnly() callbacks are re-evaluated for all properties
this.onTypeChanged();
}
Comment on lines 83 to 88

/** Get the currently selected filter value */
Expand Down Expand Up @@ -143,9 +145,9 @@ export const PropertiesWindow = GObject.registerClass({
}

case Property.Type.BOOLEAN:
suffixWidget = new Gtk.Switch({ valign: Gtk.Align.CENTER, state: value });
suffixWidget = new Gtk.Switch({ valign: Gtk.Align.CENTER, active: value });
suffixWidget.connect('notify::active', () => {
this.onValueChanged(`${property}`, suffixWidget.state);
this.onValueChanged(`${property}`, suffixWidget.active);
});
break;

Expand Down Expand Up @@ -192,6 +194,11 @@ export const PropertiesWindow = GObject.registerClass({
break;
}

// Apply readOnly state to the widget (supports static boolean or entity-parameterized callable)
const propEntity = DesignCore.PropertyManager.getEntityForProperty(selectedType, property);
const isReadOnly = typeof definition?.readOnly === 'function' ? definition.readOnly(propEntity) : !!definition?.readOnly;
Comment on lines +198 to +199
suffixWidget.set_sensitive(!isReadOnly);

// Get a formatted version of the property name
const formattedName = this.formatDisplayName(property);
const propRow = new Adw.ActionRow({ title: formattedName });
Expand Down
Loading