Feature/hatch patterns - #458
Open
dubstar-04 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Properties window’s widget behavior so boolean properties bind correctly to GTK4 Gtk.Switch, and it introduces a mechanism to re-evaluate per-property readOnly behavior after edits. It also updates the appstream/metainfo release notes.
Changes:
- Rebuild the Properties window list after a property change to re-evaluate
readOnlylogic. - Update boolean property UI to use
Gtk.Switch.activeinstead ofstate. - Add new items to the
50.alpha2release notes (including hatch pattern support).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Design/Properties/propertiesWindow.js |
Rebuilds property UI after edits; fixes GTK switch binding; applies readOnly sensitivity. |
data/io.github.dubstar_04.design.metainfo.xml |
Adds additional release-note entries for the upcoming release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
83
to
88
| onValueChanged(property, value) { | ||
| const selectedType = this.getFilterValue(); | ||
| DesignCore.PropertyManager.setEntityProperties(property, value, selectedType); | ||
| // Rebuild the widget list so readOnly() callbacks are re-evaluated for all properties | ||
| this.onTypeChanged(); | ||
| } |
Comment on lines
+198
to
+199
| const propEntity = DesignCore.PropertyManager.getEntityForProperty(selectedType, property); | ||
| const isReadOnly = typeof definition?.readOnly === 'function' ? definition.readOnly(propEntity) : !!definition?.readOnly; |
Comment on lines
+73
to
+75
| <li>Fix handling of Insert entities with no block defined</li> | ||
| <li>Fix Zoom All with invalid scale value</li> | ||
| <li>Add support for user-defined hatch patterns</li> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.