Skip to content

edit warning for test file t in #1561#1603

Merged
dondi merged 1 commit into
betafrom
kdahlquist-1561a
Jun 24, 2026
Merged

edit warning for test file t in #1561#1603
dondi merged 1 commit into
betafrom
kdahlquist-1561a

Conversation

@kdahlquist

Copy link
Copy Markdown
Collaborator

I made some tweaks to the error message for the "t" test files in issue #1561 . I did this in the web interface, so I'm not 100% I did this PR correctly, but I think so. I will add the pull request checklist shortly.

@kdahlquist

kdahlquist commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Pull Request Checklist

  • GitHub Actions C.I. build passes
  • All five Demos look as expected when loaded
  • Reload works as expected
  • Load an Excel file (GRN and PPI)
  • Load a SIF file (GRN and PPI)
  • Load a GraphML file (GRN)
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Loading a network from the database looks as expected when loaded (GRN and PPI)
  • Network can be exported to SIF (GRN and PPI) and GraphML (GRN-only)
  • Network, Expression data, and Additional Sheets can be exported to Excel
  • Image can be exported to PNG, SVG and PDF
  • Print works as expected
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Enabling and disabling node coloring works as expected
  • Node coloring options work as expected (selection top/bottom dataset, averaging values, changing max value)
  • Weighted graph loaded with the "Enable Edge Coloring" option checked appears as expected
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)
  • D-pad left/right/top/bottom/center works as expected
  • Zoom slider changes number and has effect on graph (viewport and menu)
  • Right click on a node opens gene page, page is populated with correct data (currently broken, though)

@kdahlquist

Copy link
Copy Markdown
Collaborator Author

Checklist is complete, except for known issues.

@dondi dondi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dondi dondi merged commit 91e364a into beta Jun 24, 2026
4 checks passed
@dondi dondi deleted the kdahlquist-1561a branch June 24, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants