Skip to content

Issue/660 #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bnordli wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Issue/660 #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
268b4c6
Implement IncludeNone for assembly specification #660
bnordli Jan 25, 2017
935a488
Use Assembly opt-in by default. Breaking change! #660
bnordli Jan 25, 2017
a3811d6
Simplify assembly specification #660
bnordli Jan 25, 2017
9acf4bd
More fixes
bnordli Jan 25, 2017
01d6a64
Include AssemblySpecifier for Web projects
bnordli Jan 25, 2017
a6e8e3f
Better error messages
bnordli Jan 25, 2017
65240d3
Still keep exclude
bnordli Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions Source/Bifrost.Autofac/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.Autofac/Bifrost.Autofac.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Container.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="ContainerExtensions.cs" />
Expand Down
28 changes: 0 additions & 28 deletions Source/Bifrost.Client/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions Source/Bifrost.Client/Bifrost.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<RestorePackages>true</RestorePackages>
<TargetFrameworkProfile />
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" >
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
Expand Down Expand Up @@ -62,7 +62,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
</ItemGroup>
<ItemGroup Condition=" '$(OS)' == 'Windows_NT' ">
<Compile Include="Commands\CommandForProxies.cs" />
Expand Down
14 changes: 4 additions & 10 deletions Source/Bifrost.RavenDB/AssemblySpecifier.cs → Source/Bifrost.Default/AssemblySpecifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,17 @@
* Copyright (c) 2008-2017 Dolittle. All rights reserved.
* Licensed under the MIT License. See LICENSE in the project root for license information.
*--------------------------------------------------------------------------------------------*/

using Bifrost.Configuration.Assemblies;
using Bifrost.Execution;

namespace Bifrost.RavenDB
namespace Web
{
/// <summary>
/// Reperesents an <see cref="ICanSpecifyAssemblies">assembly specifier</see> for client aspects
/// </summary>
public class AssemblySpecifier : ICanSpecifyAssemblies
{
#pragma warning disable 1591 // Xml Comments
public void Specify(IAssemblyRuleBuilder builder)
public void Specify(IAssembliesConfiguration configuration)
{
builder.ExcludeAssembliesStartingWith(
"Raven"
);
configuration.IncludeAssembliesStartingWith("Web.dll");
}
#pragma warning disable 1591 // Xml Comments
}
}
1 change: 1 addition & 0 deletions Source/Bifrost.Default/Bifrost.Default.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Configurator.cs" />
<Compile Include="ContainerCreator.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
Expand Down
24 changes: 0 additions & 24 deletions Source/Bifrost.EntityFramework/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.EntityFramework/Bifrost.EntityFramework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<Reference Include="System.Xml" />
</ItemGroup>
<ItemGroup>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Entities\ConfigurationExtensions.cs" />
<Compile Include="Entities\DbContextExtensions.cs" />
<Compile Include="Entities\EntityContext.cs" />
Expand Down
24 changes: 0 additions & 24 deletions Source/Bifrost.FluentValidation/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.FluentValidation/Bifrost.FluentValidation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="BusinessValidator.cs" />
<Compile Include="Commands\CommandBusinessValidator.cs" />
<Compile Include="Commands\CommandInputValidator.cs" />
Expand Down
24 changes: 0 additions & 24 deletions Source/Bifrost.JSON/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.JSON/Bifrost.JSON.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="ConfigurationExtensions.cs" />
<Compile Include="Events\EventSourceVersionConverter.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
Expand Down
1 change: 0 additions & 1 deletion Source/Bifrost.MongoDb/Bifrost.MongoDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Concepts\ConceptSerializationProvider.cs" />
<Compile Include="Concepts\ConceptSerializer.cs" />
<Compile Include="ConfigurationExtensions.cs" />
Expand Down
26 changes: 0 additions & 26 deletions Source/Bifrost.NHibernate/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.NHibernate/Bifrost.NHibernate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Concepts\ConceptValueType.cs" />
<Compile Include="Concepts\MappingExtensions.cs" />
<Compile Include="Concepts\ConceptAsOracleGuid.cs" />
Expand Down
24 changes: 0 additions & 24 deletions Source/Bifrost.Ninject/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.Ninject/Bifrost.Ninject.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="BindingLifecycleExtensions.cs" />
<Compile Include="Container.cs" />
<Compile Include="KernelExtensions.cs" />
Expand Down
3 changes: 1 addition & 2 deletions Source/Bifrost.QuickStart.WPF/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System.Windows;
using Bifrost.Configuration;
using Bifrost.Configuration.Assemblies;

namespace Bifrost.QuickStart.WPF
{
Expand All @@ -11,7 +10,7 @@ public partial class App : Application
{
static App()
{
Configure.DiscoverAndConfigure(a => a.IncludeAll()); //.ExceptAssembliesStartingWith("System","Microsoft","mscor","FluentValidation","Ninject"));
Configure.DiscoverAndConfigure();
}
}
}
14 changes: 4 additions & 10 deletions Source/Bifrost.MongoDb/AssemblySpecifier.cs → ...e/Bifrost.QuickStart/AssemblySpecifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,17 @@
* Copyright (c) 2008-2017 Dolittle. All rights reserved.
* Licensed under the MIT License. See LICENSE in the project root for license information.
*--------------------------------------------------------------------------------------------*/

using Bifrost.Configuration.Assemblies;
using Bifrost.Execution;

namespace Bifrost.MongoDB
namespace Web
{
/// <summary>
/// Reperesents an <see cref="ICanSpecifyAssemblies">assembly specifier</see> for client aspects
/// </summary>
public class AssemblySpecifier : ICanSpecifyAssemblies
{
#pragma warning disable 1591 // Xml Comments
public void Specify(IAssemblyRuleBuilder builder)
public void Specify(IAssembliesConfiguration configuration)
{
builder.ExcludeAssembliesStartingWith(
"MongoDB"
);
configuration.IncludeAssembliesStartingWith("Web.dll");
}
#pragma warning disable 1591 // Xml Comments
}
}
1 change: 1 addition & 0 deletions Source/Bifrost.QuickStart/Bifrost.QuickStart.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
</Content>
</ItemGroup>
<ItemGroup>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Configurator.cs" />
<Compile Include="Concepts\Persons\SocialSecurityNumber.cs" />
<Compile Include="ContainerCreator.cs" />
Expand Down
1 change: 0 additions & 1 deletion Source/Bifrost.RavenDB/Bifrost.RavenDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="DocumentStoreConfiguration.cs" />
<Compile Include="Events\RegularEventStoreConfiguration.cs" />
<Compile Include="Events\EventSubscriptions.cs" />
Expand Down
24 changes: 0 additions & 24 deletions Source/Bifrost.SimpleInjector/AssemblySpecifier.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion Source/Bifrost.SimpleInjector/Bifrost.SimpleInjector.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<Compile Include="..\Common\CommonAssemblyInfo.cs">
<Link>Properties\CommonAssemblyInfo.cs</Link>
</Compile>
<Compile Include="AssemblySpecifier.cs" />
<Compile Include="Container.cs" />
<Compile Include="ContainerExtensions.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
Expand Down
Loading