Skip to content

Issue/660 - #776

Open
bnordli wants to merge 7 commits into
dolittle:masterfrom
bnordli:issue/660
Open

Issue/660#776
bnordli wants to merge 7 commits into
dolittle:masterfrom
bnordli:issue/660

Conversation

@bnordli

@bnordli bnordli commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

BREAKING CHANGE (As discussed on multiple previous occasions.)

Turn assembly specification upside down: Clients must now specify which assemblies to be included, instead of which assemblies to be excluded.

PROS:

  • This simplifies assembly specification a lot (as this PR itself is an example of), since clients have much better knowledge of what should be in the application than what should not be in the application
  • Better control (avoid sudden initialization failures because of new dlls being unknowingly included)
  • In many cases better performance, since the sets of dlls included is bounded, instead of unbounded.

CONS:

  • Clients must remember to include new assemblies, but this will be discovered early.
  • It is a breaking change, after all, but should fit in the 2.0.0 milestone.

Fixes #660

@einari einari added this to the 1.2.0 milestone Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants