fix(base): make ChimeraX download fail loudly and retry#6
Open
Abdelsalam-Abbas wants to merge 1 commit into
Open
fix(base): make ChimeraX download fail loudly and retry#6Abdelsalam-Abbas wants to merge 1 commit into
Abdelsalam-Abbas wants to merge 1 commit into
Conversation
The ChimeraX step used a silent `curl -s | grep` pipeline whose exit status is grep's: an empty or unexpected response (e.g. blocked egress from the Harbor builder) makes grep match nothing and exit 1, aborting the build with a bare "exit code 1" and zero diagnostics -- which is exactly how it failed in CI run 28394997476. Run the token dance under bash with set -euo pipefail and curl -fsS so HTTP/network errors surface, retry transient failures, print the raw response when no download URL is found, and gate apt-get install behind dpkg-deb --info so a non-.deb payload is reported instead of silently breaking the install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI run 28394997476 failed in
Build baseatDockerfile.base:111(the ChimeraX install) with a bareexit code 1and no diagnostics:Root cause
The step was a silent pipeline:
A pipeline's exit status is its last command's —
grep, which exits1when it matches nothing. So an empty/unexpected response from the firstcurl(most likely blocked or filtered egress from the self-hosted Harbor builder towww.cgl.ucsf.edu) makes grep match nothing → the&&chain aborts withexit 1. Becausecurl -sis silent and grep's output is redirected to a file, the log shows zero clues, and curl's own exit code is masked by the pipe.The download logic itself is fine — running the same flow from a normal host returns a valid 449 MB
.deb.Fix
Run the token dance under
bash -euo pipefailwithcurl -fsS:--retry 5 --retry-all-errors);apt-get installis gated behinddpkg-deb --info, so a non-.debpayload is reported rather than silently breaking the install.Note
If the underlying cause is the runner's egress to
www.cgl.ucsf.edu, this build will still fail — but the next run's log will now say exactly why (e.g.Could not resolve host/Connection timed out), which can then be taken to whoever manages the runner's network policy.Validation
bash -nsyntax check of the embedded script passes underset -euo pipefail.