Repository navigation
fix(ci,testing): four CI flakes — helm spawnSync wait, re-run merges stale parts, Chrome component extensions, profile-writer race - #746
Merged
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 108 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (15)
Comment |
…stale parts, Chrome component extensions, late-profile-writer race - scaffold-helm-retire.test.ts awaits `helm template` (Bun.spawn + SIGKILL deadline) instead of Bun.spawnSync, whose wait inside a `bun test --parallel` worker missed helm's exit: exit 0 with empty stdout at exactly 30000 ms (run 37882529833), or no wake at all until the unit step's 480 s deadline (12 runs 2026-10-08/09). No network: no chart deps, --kube-version. - ci.yml names each gate part by github.run_attempt (artifact and file), and the verify job merges each part's newest attempt via scripts/verify-parts.ts (lib/ci-attempt-parts.ts, tested): run 37918316075 attempt 2 merged attempt 1's red unit-1 beside the green rerun. - launchChrome passes --disable-component-extensions-with-background-pages: the hangouts component extension's thunk.js was paused by x shot's browser-wide Fetch and logged as an off-list request (run 37879355801). Held by e2e/cdp-launch-targets.e2e.test.ts. - The outside-group profile writer test drives remove() with a settle wider than its writer; ThrowawayProfile.remove takes settleMs. A forking 5 ms poller lost to the 50 ms settle on a loaded runner (run 37945274280, packages 2/2); reproduced by delaying the writer 100 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sebyx07
force-pushed
the
ci/flakes-helm-attempt-parts-chrome
branch
from
October 9, 2026 15:38
604b7cf to
dc58cf6
Compare
…rome's own browser_ui CI's Chrome build lists browser_ui chrome://omnibox-popup targets beside the page; they load no web resource. An extension page or worker is what interception paused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes for the flakes that made every release need manual reruns.
scaffold-helm-retire.test.tshangs, worker SIGKILL at theunitstep's 480 sBun.spawnSyncinside abun test --parallelworker missed helm's exit (helm had rendered and exited 0); the sync wait also holds the event loop, so the test timeout can't fire. Not network: no chart deps,--kube-versionsetBun.spawnwith its own SIGKILL deadline; the wait ends on exit, not pipe EOF; failure names the chart and how it endedverifydownloaded attempt 1's redverify-part-unit-1(artifact ids aren't time-ordered) beside the green rerungithub.run_attempt;scripts/verify-parts.ts(lib/ci-attempt-parts.ts, unit-tested) handsx verify mergeeach part's newest attemptx shotpopup e2e: extrachrome-extension://nkeimhogjdpnpccoofpliimaahmaaome/thunk.jsrefused--disable-extensionsleaves Google Chrome's component extensions running; browser-wide Fetch paused one--disable-component-extensions-with-background-pages; new e2e asserts a fresh launch has onlypage about:blank(red without the flag)packages (2/2)sleep/mkdirreacted slower than the 50 ms settle on a loaded runner (reproduced by delaying the writer 100 ms)remove()with a settle wider than its writer (settleMsparam)Not fixed here (listed with evidence in the report):
push-send-deadline(already fixed by #718),client-navigation-swap"another surface" (1×, 123 ms, no output kept),isolated-pluginsGC count (1×, no values kept: attempt-named artifacts now keep them), Docker Hubunauthorizedpullingversitygw(registry).Proof: this PR's CI green on attempt 1.
🤖 Generated with Claude Code