Skip to content

chore(ci): run CI on GitHub-hosted runners, drop Blacksmith #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebyx07 merged 1 commit into from
Oct 7, 2026
Merged

chore(ci): run CI on GitHub-hosted runners, drop Blacksmith #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ jobs:
bun:
name: bun (lint + typecheck + test)
# Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite.
runs-on: blacksmith-2vcpu-ubuntu-2204
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).
Comment on lines 15 to +16

@developerz-ai developerz-ai Bot Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The diff retires the Blacksmith runner but leaves line 15 describing the job as a "Blacksmith 2 vCPU runner", directly contradicting the new GitHub-hosted comment and runs-on: ubuntu-22.04 added right below it. Delete the stale line, keeping only the GitHub-hosted note.

Suggested change
# Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite.
runs-on: blacksmith-2vcpu-ubuntu-2204
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).

grounded: src/services/session-builder.ts:246, src/adapters/android/android-adapter.ts:267, src/adapters/android/commands.ts:72 …

runs-on: ubuntu-22.04

@developerz-ai developerz-ai Bot Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs This swap falsifies the test-step comment at lines 122-125 that blames the BrowserAdapter flake on "the runner's parallel 2-vCPU load": GitHub-hosted ubuntu-22.04 standard runners are 4-vCPU, so the stated cause no longer matches the runner this job executes on. Reword it to the parallel bun-test file load so the skip doesn't read as Blacksmith-specific and get re-enabled on the new runner.

grounded: .github/workflows/ci.yml, src/adapters/browser/browser-adapter.ts:371, src/adapters/browser/browser-adapter.integration.test.ts …

# 10 was too tight (run 34577257568 was cancelled at 10m17s mid-install).
# 20 now exists for the retry's sake, not to accommodate a hang: three
# bounded attempts (3 × 300s) + backoff (20s + 40s) + ~30s for the rest of
Expand Down
Loading