Repository navigation
chore(ci): run CI on GitHub-hosted runners, drop Blacksmith - #90
Conversation
Public repo → GitHub-hosted runners (free for public repos). Blacksmith is retired org-wide. - ci.yml: blacksmith-2vcpu-ubuntu-2204 → ubuntu-22.04. release.yml (npm OIDC) already on ubuntu-latest, unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🟡 Reviewed2 actionable comment(s) · grounded on your code ⏱ 4m 28s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used🪛 zizmor (1.30.1).github/workflows/ci.yml[warning] 13-133: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block (excessive-permissions) 🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe ChangesCI runner selection
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The public-repository runner choice matches the documented rule, and no merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the runner's name, Comment |
There was a problem hiding this comment.
Review summary — 1 file(s), 2 finding(s).
Critical 0 · Major 0 · Minor 2 · Nit 0
One-line runner swap blacksmith-2vcpu-ubuntu-2204 → ubuntu-22.04; the label is valid and the move itself is safe. Two stale comments remain: line 15 still says "Blacksmith 2 vCPU runner", and the test-skip rationale cites the old runner's 2-vCPU load.
| File | Findings |
|---|---|
.github/workflows/ci.yml |
2 minor |
Config notes
- CI checks were not shown to the reviewer — GitHub reported no checks on the commit under review, so this review judged the diff without a build result
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by zai/glm-5.3-flash on box sebby-ovh-2 — 12.7k in / 9.43k out over 1 call, ~<$0.01 on your key (estimate: list price x reported tokens).
| # Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite. | ||
| runs-on: blacksmith-2vcpu-ubuntu-2204 | ||
| # GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted). |
There was a problem hiding this comment.
minor · docs The diff retires the Blacksmith runner but leaves line 15 describing the job as a "Blacksmith 2 vCPU runner", directly contradicting the new GitHub-hosted comment and runs-on: ubuntu-22.04 added right below it. Delete the stale line, keeping only the GitHub-hosted note.
| # Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite. | |
| runs-on: blacksmith-2vcpu-ubuntu-2204 | |
| # GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted). | |
| # GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted). |
grounded: src/services/session-builder.ts:246, src/adapters/android/android-adapter.ts:267, src/adapters/android/commands.ts:72 …
| # Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite. | ||
| runs-on: blacksmith-2vcpu-ubuntu-2204 | ||
| # GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted). | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
minor · docs This swap falsifies the test-step comment at lines 122-125 that blames the BrowserAdapter flake on "the runner's parallel 2-vCPU load": GitHub-hosted ubuntu-22.04 standard runners are 4-vCPU, so the stated cause no longer matches the runner this job executes on. Reword it to the parallel bun-test file load so the skip doesn't read as Blacksmith-specific and get re-enabled on the new runner.
grounded: .github/workflows/ci.yml, src/adapters/browser/browser-adapter.ts:371, src/adapters/browser/browser-adapter.integration.test.ts …
Org rule (2026-10-07): private repos run CI on Ubicloud standard runners, public repos on GitHub-hosted runners; Blacksmith is retired.
Public repo → GitHub-hosted runners (free for public repos). Blacksmith is retired org-wide.
The checks on this PR run on the new runners — they are the proof.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit