Skip to content

chore(ci): run CI on GitHub-hosted runners, drop Blacksmith - #90

Merged
sebyx07 merged 1 commit into
mainfrom
chore/ci-runners-github-hosted
Oct 7, 2026
Merged

sebyx07 merged 1 commit into
mainfrom
chore/ci-runners-github-hosted

Conversation

@sebyx07

@sebyx07 sebyx07 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Org rule (2026-10-07): private repos run CI on Ubicloud standard runners, public repos on GitHub-hosted runners; Blacksmith is retired.

Public repo → GitHub-hosted runners (free for public repos). Blacksmith is retired org-wide.

  • ci.yml: blacksmith-2vcpu-ubuntu-2204 → ubuntu-22.04. release.yml (npm OIDC) already on ubuntu-latest, unchanged.

The checks on this PR run on the new runners — they are the proof.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration environment to run on a GitHub-hosted runner. This is an internal change and does not alter application features or behavior.

Public repo → GitHub-hosted runners (free for public repos). Blacksmith is retired org-wide.
- ci.yml: blacksmith-2vcpu-ubuntu-2204 → ubuntu-22.04. release.yml (npm OIDC) already on ubuntu-latest, unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@developerz-ai

developerz-ai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Reviewed

2 actionable comment(s) · grounded on your code

⚠️ 2 config note(s): CI checks were not shown to the reviewer — GitHub reported no checks on the commit under review, so this review judged the diff without a build result · test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 4m 28s wall clock · glm-5.3-flash via zai · 1 model call(s) · 9,433 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: cf4aed77-9ab1-4c5d-b1e3-fa83a29f11aa
📥 Commits

Reviewing files that changed from the base of the PR and between 34df0ee and aac336e.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: bun (lint + typecheck + test)
  • GitHub Check: developerz.ai review
🧰 Additional context used
🪛 zizmor (1.30.1)
.github/workflows/ci.yml

[warning] 13-133: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

🔇 Additional comments (1)
.github/workflows/ci.yml (1)

16-17: LGTM!


📝 Walkthrough

Walkthrough

The bun CI job now runs on ubuntu-22.04 instead of the Blacksmith 2-vCPU runner. Its adjacent comment now describes the runner selection rule.

Changes

CI runner selection

Layer / File(s) Summary
Update bun runner selection
.github/workflows/ci.yml
The bun job now uses the GitHub-hosted ubuntu-22.04 runner. The adjacent comment describes the runner selection rule.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to aac33

The public-repository runner choice matches the documented rule, and no merge-blocking issue was identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving CI from Blacksmith to GitHub-hosted runners.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the runner's name,
And finds ubuntu-22.04 in the game.
The workflow hops along its way,
With comments clear about the play.
One small change, then off I go,
To nibble greens beneath the snow.

Comment @coderabbitai help to get the list of available commands.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 2 finding(s).

Critical 0 · Major 0 · Minor 2 · Nit 0

One-line runner swap blacksmith-2vcpu-ubuntu-2204 → ubuntu-22.04; the label is valid and the move itself is safe. Two stale comments remain: line 15 still says "Blacksmith 2 vCPU runner", and the test-skip rationale cites the old runner's 2-vCPU load.

File Findings
.github/workflows/ci.yml 2 minor
Config notes
  • CI checks were not shown to the reviewer — GitHub reported no checks on the commit under review, so this review judged the diff without a build result
  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by zai/glm-5.3-flash on box sebby-ovh-2 — 12.7k in / 9.43k out over 1 call, ~<$0.01 on your key (estimate: list price x reported tokens).

Comment thread .github/workflows/ci.yml
Comment on lines 15 to +16
# Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite.
runs-on: blacksmith-2vcpu-ubuntu-2204
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The diff retires the Blacksmith runner but leaves line 15 describing the job as a "Blacksmith 2 vCPU runner", directly contradicting the new GitHub-hosted comment and runs-on: ubuntu-22.04 added right below it. Delete the stale line, keeping only the GitHub-hosted note.

Suggested change
# Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite.
runs-on: blacksmith-2vcpu-ubuntu-2204
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).

grounded: src/services/session-builder.ts:246, src/adapters/android/android-adapter.ts:267, src/adapters/android/commands.ts:72 …

Comment thread .github/workflows/ci.yml
# Blacksmith 2 vCPU runner — fast on small matrices, plenty for this suite.
runs-on: blacksmith-2vcpu-ubuntu-2204
# GitHub-hosted runner (org rule: private repos on Ubicloud, public on GitHub-hosted).
runs-on: ubuntu-22.04

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs This swap falsifies the test-step comment at lines 122-125 that blames the BrowserAdapter flake on "the runner's parallel 2-vCPU load": GitHub-hosted ubuntu-22.04 standard runners are 4-vCPU, so the stated cause no longer matches the runner this job executes on. Reword it to the parallel bun-test file load so the skip doesn't read as Blacksmith-specific and get re-enabled on the new runner.

grounded: .github/workflows/ci.yml, src/adapters/browser/browser-adapter.ts:371, src/adapters/browser/browser-adapter.integration.test.ts …

@sebyx07
sebyx07 merged commit 13ad187 into main Oct 7, 2026
2 checks passed
@sebyx07
sebyx07 deleted the chore/ci-runners-github-hosted branch October 7, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant