Skip to content

derive helm action from release intent - #158

Merged
atkrad merged 3 commits into
mainfrom
derive-helm-action-from-release-intent
Sep 25, 2026
Merged

atkrad merged 3 commits into
mainfrom
derive-helm-action-from-release-intent

Conversation

@atkrad

@atkrad atkrad commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Decide Helm install, upgrade, or none by comparing the previous release with the rendered manifest and hooks.
  • Do not let live drift, a missing live object, or predictor output decide whether Helm runs.
  • Skip namespace and Helm write prediction when Helm will not run, so the plan has no Helm write consequences for that invocation.

Related

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- compare previous and desired manifests and hooks
- skip write prediction when helm will not run
- keep live drift from deciding a helm upgrade
@atkrad atkrad added the kind/bug Something is broken label Sep 24, 2026
@github-actions github-actions Bot added area/deploy Deploy and plan session flow area/testing Scenarios, harness, goldens labels Sep 24, 2026
@atkrad atkrad self-assigned this Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 10 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/plan/release_intent.go 88.88% 7 Missing ⚠️
internal/plan/semantic_build.go 88.46% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@atkrad
atkrad merged commit f8b41b2 into main Sep 25, 2026
17 checks passed
@atkrad
atkrad deleted the derive-helm-action-from-release-intent branch September 25, 2026 11:02
@atkrad atkrad mentioned this pull request Sep 25, 2026
7 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow area/testing Scenarios, harness, goldens kind/bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant