Skip to content

carry helm action into deploy plan - #159

Merged
atkrad merged 1 commit into
mainfrom
carry-helm-action-into-deploy-plan
Sep 25, 2026
Merged

atkrad merged 1 commit into
mainfrom
carry-helm-action-into-deploy-plan

Conversation

@atkrad

@atkrad atkrad commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Store the previous Helm release (manifest and declarative hooks from prep.Current) on the render result.
  • Derive the semantic Helm action from that same render and keep it on the deploy plan.
  • Leave the real deploy gate on the legacy diff, so Helm still runs or skips as it does today.

Related

Refs #158

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- store the previous release intent on the render result
- derive the semantic helm action from that same render
- leave the deploy execution gate unchanged
@github-actions github-actions Bot added area/cli Commands, flags, UX copy area/helm Chart render, release, post-render area/deploy Deploy and plan session flow labels Sep 25, 2026
@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes labels Sep 25, 2026
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@atkrad atkrad self-assigned this Sep 25, 2026
@atkrad
atkrad merged commit fc3567c into main Sep 25, 2026
17 checks passed
@atkrad
atkrad deleted the carry-helm-action-into-deploy-plan branch September 25, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Commands, flags, UX copy area/deploy Deploy and plan session flow area/helm Chart render, release, post-render kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant