feat: sdk trigger area#5244
Merged
Merged
Conversation
This was referenced Sep 2, 2025
…tityTriggerArea) support detecting any kind of scene entity with colliders
…SDKEntityTriggerArea layer [WIP]
mikhail-dcl
requested changes
Sep 24, 2025
mikhail-dcl
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good. I simply have minor requests
mikhail-dcl
self-requested a review
September 25, 2025 12:50
mikhail-dcl
approved these changes
Sep 25, 2025
…d Container' asset
…-explorer into feat/sdk-trigger-area
Member
Author
|
I'll update the protocol package to point to the latest |
DafGreco
approved these changes
Sep 29, 2025
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️ ] Teleport with map/coordinates/Jump In
- [ ✔️] Chat and multiplayer
- [✔️ ] Profile card
- [✔️ ] Camera
- [✔️ ] Skybox
Evidence of windows and macos :
20250929-0835-23.0295037.mp4
20250929-0837-41.1452312.mp4
pravusjif
enabled auto-merge (squash)
September 29, 2025 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
WHY
We need support for the new
TriggerAreaandTriggerAreaResultcomponents from the protocol, to be able to expose through the SDK interface the ability to use Unity's Trigger Colliders to detect OnEnter/OnStay/OnExit of scene Entities (and players) based on the SDK ColliderLayer layermask.WHAT
CharacterTriggerAreaplugin and logic (previously used only forCameraModeAreaandAvatarModifierAreacomponents handling) into the newSDKEntityTriggerAreato:AllAvatarsphysics layer as an optimization to use that one onSDKEntityTriggerAreathat only care for player avatarsBoxColliderandSphereColliderdisabled and enables the one it needsTriggerAreaHandlerSystemfor the new SDK componentTEST TINSTRUCTIONS
pravus.dcl.ethworldScreen.Recording.2025-09-24.at.1.53.59.PM.mp4