Skip to content

feat: trigger area components#306

Merged
pravusjif merged 8 commits into
mainfrom
feat/trigger-area-components
Sep 29, 2025
Merged

feat: trigger area components#306
pravusjif merged 8 commits into
mainfrom
feat/trigger-area-components

Conversation

@pravusjif

@pravusjif pravusjif commented Sep 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@pravusjif pravusjif self-assigned this Sep 2, 2025
@github-actions

github-actions Bot commented Sep 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Test this pull request

  • The @dcl/protocol package can be tested in scenes by running 
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-18102915354.commit-ca848f3.tgz"

This was referenced Sep 2, 2025
Closed
Merged
Merged
Merged
@pravusjif
pravusjif marked this pull request as ready for review September 24, 2025 14:30
robtfm
robtfm reviewed Sep 24, 2025
View reviewed changes
Comment thread proto/decentraland/sdk/components/mesh_collider.proto Outdated
Comment thread proto/decentraland/sdk/components/trigger_area_result.proto Outdated
@pravusjif
renamed layers field
701cc2b 
Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif
renamed CL_RESERVED1 to CL_PLAYER
2c7009e 
Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif
added comment
f43c58d 
Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif

pravusjif commented Sep 28, 2025

Copy link
Copy Markdown
Member Author

a7hzfd

kuruk-mm
kuruk-mm previously approved these changes Sep 29, 2025
View reviewed changes

@kuruk-mm kuruk-mm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@pravusjif
added allow_alias in ColliderLayer enum for deprecated reference
0c5c2a8 
Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif

pravusjif commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

I'll merge the change since we know that we are renaming a RESERVED CollisionLayer field and it's completely under our control 👍 .

For other cases the compatibility validation should not be bypassed.

kuruk-mm
kuruk-mm approved these changes Sep 29, 2025
View reviewed changes

@kuruk-mm kuruk-mm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved

@pravusjif
pravusjif merged commit 258fabc into main Sep 29, 2025
2 of 3 checks passed
@pravusjif
pravusjif deleted the feat/trigger-area-components branch September 29, 2025 16:12
This was referenced Sep 30, 2025
Closed
Closed
@kuruk-mm kuruk-mm mentioned this pull request Dec 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robtfm robtfm robtfm left review comments
@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees

@pravusjif pravusjif

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pravusjif @kuruk-mm @robtfm