Repository navigation
FEAT: render the top bar from a navItems list - #181
Conversation
|
I've got a few questions about this PR:
|
decay71
left a comment
There was a problem hiding this comment.
Thanks, this is clean work and it ran without problems on our side in mock mode.
Before we go further I would like to understand the idea behind putting the navigation on the left. Do you have that many tabs planned (preview, history, queue, favorites and so on), or do you think the left side is better for other reasons?
From my side the width is the critical resource. The dashboard puts the ACE cards, the four toolhead cards and the wiring next to each other, and in head mode with several ACEs it gets tight already. With the rail open, at 1024 px the fourth toolhead card drops into a second row, while the current top bar keeps all four in one row. In return we gain only about 50 px of height.
If more tabs are coming, I would rather group them: for example one "Print" tab in the top bar, and inside it a second row of tabs for preview, history, queue and so on. That keeps the top bar short however many features we add, and it works on touch screens without hover menus.
What I would take right away is the first commit: rendering the tabs from one railItems list is a good change on its own, and it fits a grouped menu as well. What do you think?
On the printer it only shows up as the Fluidd camera tile (?panel=1), where the rail is not rendered anyway.
|
Sounds good, go ahead with trimming this PR to the first commit and the separate grouped-bar PR. |
|
Pardon, I didn't notice that. Anyway it is a bit confusing because it's a bit generic and it sounds like a tab containing a report of some sort, but maybe that's just me. I can always park that and/or do it later. |
Replace the hand-written tab buttons with one list (navItems) that the top bar renders. Same tabs, same order, same conditions, no visual change. A feature adds its tab by adding one entry to the list instead of editing the markup.
14858f7 to
d9e9f7d
Compare
|
No problem, I see your point, but I would keep "Dashboard". It is the overview of ACEs and heads and has been called that from the start, and the README and guides use it. Let's park the rename and leave it out of the trimmed PR and the grouped-bar PR. |


The top bar's tab buttons are now rendered from one list,
navItems, instead of hand-written markup. Same tabs, order and conditions, so there is no visual change. A feature adds its tab by adding one entry to the list.This is the first commit of the earlier navigation-rail work, trimmed as discussed; the grouped top bar will follow as a separate PR.