Repository navigation
FEAT: group tabs in the top bar - #184
Merged
Merged
Conversation
navItems entries may now carry a group key. The top bar shows one entry for each group that has at least one child (Print Hub, placed before Spools), and a second row lists the children while one of them is open. Choosing a group opens the child that was open last, or its first child. A group without children is not shown, so nothing changes visibly until a feature adds its first tab to Print Hub.
The second row uses the same underline marker as the top bar in the new design (theme tokens only, so the light shade follows) and the existing button look in classic. On phones the row scrolls horizontally and the buttons keep a 44px touch height.
Collaborator
Author
|
Classic Theme: Dark Theme: Light Theme: Mobile View (Dark): |
decay71
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #181: the top bar can now group tabs, with a second row for the children of the open group. This is the structure for the Print Hub (Control, History, Queue, Favorites) that I plan to add, one tab per PR.
What changes
navItemsentries may carry agroupkey. The top bar shows one entry per group that has at least one child (placed before Spools), and a second row lists the children while one of them is open.ui.tabs.print_hub, added in en, de and zh) and stays hidden until it has a child, so nothing changes visibly in this PR. The first tab PR makes it appear.To try it: add
items.push({key: "queue", group: "printhub", label: "Queue"})tonavItemsand add"queue"to_validTabs. The screenshots below were taken with three such temporary tabs.Known limits: the second row is not sticky, only the top bar stays pinned while scrolling.