feat(debug): replace tmate with upterm - #67
Merged
Conversation
## Short Summary (TL;DR) The tmate servers have been shut down, so `debug_enabled` never produces a usable session. Switch to upterm, which fixes the debug session for every add-on using this action, without any of them having to change. ## The Issue - tmate-io/tmate#322 Same change as ddev/ddev#8789. ## How This PR Solves The Issue Swap `mxschmitt/action-tmate` for `owenthereal/action-upterm`, pinned to the v1.15.0 SHA the same way tmate was. The upterm action has no `github-token` input, so that line is dropped; `token` is still used by the `Run test` step. The `debug_enabled` description no longer names the tool. Add-ons copy that label into their own `tests.yml`, and naming the tool means renaming it in 30-odd repos every time the tool changes. ## Manual Testing Instructions Dispatch the tests workflow with `debug_enabled` checked and confirm the `Setup upterm session` step prints an `ssh ...@uptermd.upterm.dev` address you can connect to. ## Automated Testing Overview None. The step only runs on `workflow_dispatch` with `debug_enabled`. ## Release/Deployment Notes Needs a v2.5.0 release with `v2` re-pointed at it, which is what gets the fix to the add-ons. The CHANGELOG entry references PR #67; correct it if this lands under a different number. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
The tmate servers have been shut down, so
debug_enablednever produces a usable session. Switch to upterm, which fixes the debug session for every add-on using this action, without any of them having to change.The Issue
Same change as ddev/ddev#8789.
How This PR Solves The Issue
Swap
mxschmitt/action-tmateforowenthereal/action-upterm, pinned to the v1.15.0 SHA the same way tmate was. The upterm action has nogithub-tokeninput, so that line is dropped;tokenis still used by theRun teststep.The
debug_enableddescription no longer names the tool. Add-ons copy that label into their owntests.yml, and naming the tool means renaming it in 30-odd repos every time the tool changes.Manual Testing Instructions
Dispatch the tests workflow with
debug_enabledchecked and confirm theSetup upterm sessionstep prints anssh ...@uptermd.upterm.devaddress you can connect to.Automated Testing Overview
None. The step only runs on
workflow_dispatchwithdebug_enabled.Release/Deployment Notes
Needs a v2.5.0 release with
v2re-pointed at it, which is what gets the fix to the add-ons.The CHANGELOG entry references PR #67; correct it if this lands under a different number.
🤖 Generated with Claude Code