Satisfy updated DDEV add-on maintenance checker rules - #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
Three text-only edits under
.github/so the scheduled DDEV add-on update checker passes again. No behaviour change.The Issue
The checker script is fetched live from ddev.com, and DDEV tightened three rules upstream: the PR template must open with a
## Short Summary (TL;DR)section, its testing command must use the newddev add-on get <owner>/<repo> --pr Nform, andtests.ymlmust not mention tmate. The tmate servers were shut down andddev/github-action-add-on-test@v2already switched to upterm (ddev/github-action-add-on-test#67), so only the copied input label was stale.How This PR Solves The Issue
PULL_REQUEST_TEMPLATE.md: add the Short Summary section and switch the manual-testing command to the--prflag.tests.yml: rename thedebug_enableddescription to the tool-neutral upstream wording, "Enable remote debugging session".Manual Testing Instructions
curl -fsSL https://ddev.com/s/addon-update-checker.sh | bashShould print "All checks passed, no actions needed." Verified locally on this branch.
Automated Testing Overview
The
maintenance-checkworkflow runs the same script on this PR.Release/Deployment Notes
None. Once merged, the next scheduled run will pass and the issue can stay closed.