Skip to content

feat(branding): replace the legacy WiFiDAQ icon with the DAQiFi brand icon #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cptkoolbeenz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(branding): replace the legacy WiFiDAQ icon with the DAQiFi brand icon #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfa1ee3
feat(branding): replace the legacy WiFiDAQ icon with the DAQiFi brand…
cptkoolbeenz Aug 19, 2026
237f382
feat(branding): update to the final app icon
cptkoolbeenz Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Daqifi.Desktop/Daqifi.Desktop.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
<NoWarn>CA1416</NoWarn>
</PropertyGroup>
<PropertyGroup>
<ApplicationIcon>Images\WiFiDAQ.ico</ApplicationIcon>
<!-- Multi-resolution brand icon: 16-64px carry the traces mark, 128/256 the
full DAQiFi lockup, since the wordmark is unreadable at taskbar size.
Generated by daqifi-design-tokens/assets/app-icons — do not hand-edit. -->
<ApplicationIcon>Images\AppIcon.ico</ApplicationIcon>
Comment on lines +17 to +20

@qodo-code-review qodo-code-review Bot Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Icon entries use tab indentation 📘 Rule violation ✧ Quality

The newly added icon comment and ApplicationIcon entry begin with tabs instead of four-space
indentation. Additional changed resource entries follow the same prohibited tab-based indentation.
Agent Prompt 
## Issue description
Newly added XML lines use tab characters for indentation, violating the required four-space indentation convention.

## Issue Context
Convert leading tabs on all added icon-related entries to four spaces per indentation level while preserving the XML structure.

## Fix Focus Areas
- Daqifi.Desktop/Daqifi.Desktop.csproj[17-20]
- Daqifi.Desktop/Daqifi.Desktop.csproj[35-35]
- Daqifi.Desktop/Daqifi.Desktop.csproj[79-79]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

<AssemblyName>DAQiFi</AssemblyName>
<ApplicationManifest Condition="'$(Configuration)'=='Debug'">app.Debug.manifest</ApplicationManifest>
<ApplicationManifest Condition="'$(Configuration)'!='Debug'">app.manifest</ApplicationManifest>
Expand All @@ -29,7 +32,7 @@
</PropertyGroup>
<ItemGroup>
<None Remove="Images\DAQiFi.png" />
<None Remove="Images\WiFiDAQ.ico" />
<None Remove="Images\AppIcon.ico" />
</ItemGroup>
<ItemGroup>
<Content Include="e_sqlite3.dll">
Expand Down Expand Up @@ -73,7 +76,7 @@

<ItemGroup>
<Resource Include="Images\DAQiFi.png" />
<Resource Include="Images\WiFiDAQ.ico" />
<Resource Include="Images\AppIcon.ico" />
</ItemGroup>

</Project>
Binary file added Daqifi.Desktop/Images/AppIcon.ico
View file
Open in desktop
Binary file not shown.
Binary file removed Daqifi.Desktop/Images/WiFiDAQ.ico
View file
Open in desktop
Binary file not shown.
Loading