feat(branding): replace the legacy WiFiDAQ icon with the DAQiFi brand icon - #826
Open
cptkoolbeenz wants to merge 2 commits into
Open
feat(branding): replace the legacy WiFiDAQ icon with the DAQiFi brand icon#826cptkoolbeenz wants to merge 2 commits into
cptkoolbeenz wants to merge 2 commits into
Conversation
… icon WiFiDAQ.ico was not the DAQiFi logo — a green/blue "W" waveform mark predating the current brand — and it carried a single 96x96 entry, so Windows downscaled it to 16px for the taskbar. AppIcon.ico is multi-resolution with a DIFFERENT image per size: the traces mark at 16/24/32/48/64 and the full DAQiFi lockup at 128/256. Windows picks the closest entry, so the taskbar and Explorer get something legible rather than a shrunken wordmark. Generated by daqifi-design-tokens/assets/app-icons from the brand's own artwork (logo-primary-light, logo-icon-traces, and the Illustrator wave export), so it matches what the Avalonia port and the Android app now ship. Regenerate there rather than editing this file.
Contributor
PR Summary by QodoReplace legacy desktop icon with multi-resolution DAQiFi branding
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Contributor
Code Review by Qodo
1. Icon entries use tab indentation
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+17
to
+20
| <!-- Multi-resolution brand icon: 16-64px carry the traces mark, 128/256 the | ||
| full DAQiFi lockup, since the wordmark is unreadable at taskbar size. | ||
| Generated by daqifi-design-tokens/assets/app-icons — do not hand-edit. --> | ||
| <ApplicationIcon>Images\AppIcon.ico</ApplicationIcon> |
Contributor
There was a problem hiding this comment.
1. Icon entries use tab indentation 📘 Rule violation ✧ Quality
The newly added icon comment and ApplicationIcon entry begin with tabs instead of four-space indentation. Additional changed resource entries follow the same prohibited tab-based indentation.
Agent Prompt
## Issue description
Newly added XML lines use tab characters for indentation, violating the required four-space indentation convention.
## Issue Context
Convert leading tabs on all added icon-related entries to four spaces per indentation level while preserving the XML structure.
## Fix Focus Areas
- Daqifi.Desktop/Daqifi.Desktop.csproj[17-20]
- Daqifi.Desktop/Daqifi.Desktop.csproj[35-35]
- Daqifi.Desktop/Daqifi.Desktop.csproj[79-79]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Picks up the composition settled on a real launcher: traces + DAQIFI over a low wave band on white, the same icon the Avalonia port now ships on Android, desktop and iOS. The two applications look like one product. Only the 16 and 24px entries still carry the traces mark alone — a wordmark of any size is an unreadable smudge there. Generated by daqifi-design-tokens/assets/app-icons (9182a97).
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 57.7%
Daqifi.Desktop.Common - 46.9%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Swaps
WiFiDAQ.icoforAppIcon.ico, generated from the brand's own artwork. Three files.Two problems with the old icon
WiFiDAQ.icois a green/blue "W" waveform mark predating the current brand — unrelated to the wordmark and traces used everywhere else..icois a container that can carry several resolutions; with only one, Windows downscales 96→16 for the taskbar.The replacement
AppIcon.icocarries seven entries, with a different image per size:Windows picks the closest entry, so small contexts get a legible mark instead of a wordmark shrunk past readability. The wordmark stops reading below roughly 64px — measured while choosing the design, not assumed.
Provenance
Generated by
daqifi-design-tokens/assets/app-iconsfromlogo-primary-light.png,logo-icon-traces.png, and the Illustrator wave export already in that repo. No redraws. The same set now supplies the Avalonia port and the Android app, so all three ship a consistent icon.Regenerate in the tokens repo rather than editing this file.
Scope
Only the
.icoswap and its threecsprojreferences. Unrelated working-tree files in my checkout (.csproj.user, a WPF temp csproj,MPLABXLog.xml) were deliberately left unstaged.Note if you diff locally: my checkout's
mainwas 5 commits behind, sogit diff main...HEADshows other people's merged work too (including anNCalcSyncbump that isn't mine). Againstorigin/mainit's 3 files, 6 insertions.🤖 Generated with Claude Code