Skip to content

Refactor: Put long node error inside html details #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orta merged 2 commits into from
Jul 31, 2023
Merged

Refactor: Put long node error inside html details #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5499691
Put long node error inside html details
glensc Jul 30, 2023
5855ac9
Remove invalid "sh" syntax for node traces
glensc Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/commands/utils/reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { DangerResults } from "../../dsl/DangerResults"

export const markdownCode = (string: string): string => `
\`\`\`sh
\`\`\`
${string}
\`\`\`
`
Expand Down
3 changes: 2 additions & 1 deletion source/commands/utils/runDangerSubprocess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ export const runDangerSubprocess = (
d(`Handling fail from subprocess`)
process.exitCode = code

const failResults = resultsWithFailure(`\`${processDisplayName}\` failed.`, "### Log\n\n" + markdownCode(allLogs))
const moreMarkdown = "### Log\n\n<details>\n\n" + markdownCode(allLogs) + "\n\n</details>\n"
const failResults = resultsWithFailure(`\`${processDisplayName}\` failed.`, moreMarkdown)
if (results) {
results = mergeResults(results, failResults)
} else {
Expand Down