Skip to content

Make SparkWriteBuilder and SparkWrite classes public #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daksha121 wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Make SparkWriteBuilder and SparkWrite classes public #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6e3e7e
DSV2 micro_batch read - implement skipReplace and skipDelete (#1)
SreeramGarlapati Jun 26, 2021
51df3d3
implement skipDelete and skipReplace (#2)
SreeramGarlapati Jun 26, 2021
2b3e7e3
Merge branch 'apache:master' into master
daksha121 Jun 29, 2021
40eeb25
Revert "DSV2 micro_batch read - implement skipReplace and skipDelete …
Jun 29, 2021
7bb4f90
Spark3 Streaming Read: Adding options to skip delete and replace snap…
Jun 29, 2021
8a6b56e
Fixed spacing
Jun 29, 2021
cd77ec2
Merge pull request #3 from daksha121/stream.read.ignore.delete.and.re…
SreeramGarlapati Jun 29, 2021
b58f374
Merge branch 'master' of https://github.com/daksha121/iceberg
daksha121 Jul 16, 2021
e99870d
Make SparkWrite classes public
daksha121 Jul 16, 2021
28b7064
Revert "Merge branch 'master' of https://github.com/daksha121/iceberg"
daksha121 Jul 16, 2021
c28a99f
Merge with master
daksha121 Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spark3/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
import static org.apache.iceberg.TableProperties.WRITE_TARGET_FILE_SIZE_BYTES;
import static org.apache.iceberg.TableProperties.WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT;

class SparkWrite {
public class SparkWrite {
private static final Logger LOG = LoggerFactory.getLogger(SparkWrite.class);

private final JavaSparkContext sparkContext;
Expand Down
2 changes: 1 addition & 1 deletion spark3/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
import org.apache.spark.sql.types.StructType;
import org.apache.spark.sql.util.CaseInsensitiveStringMap;

class SparkWriteBuilder implements WriteBuilder, SupportsDynamicOverwrite, SupportsOverwrite {
public class SparkWriteBuilder implements WriteBuilder, SupportsDynamicOverwrite, SupportsOverwrite {

private final SparkSession spark;
private final Table table;
Expand Down
26 changes: 26 additions & 0 deletions spark3/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,32 @@ public void testReadStreamWithSnapshotTypeReplaceIgnoresReplace() throws Excepti
Assertions.assertThat(actual).containsExactlyInAnyOrderElementsOf(Iterables.concat(expected));
}

@SuppressWarnings("unchecked")
@Test
public void testReadStreamWithSnapshotTypeReplaceAndSkipReplaceOption() throws Exception {
// fill table with some data
List<List<SimpleRecord>> dataAcrossSnapshots = TEST_DATA_MULTIPLE_SNAPSHOTS;
appendDataAsMultipleSnapshots(dataAcrossSnapshots, tableIdentifier);

table.refresh();

// this should create a snapshot with type Replace.
table.rewriteManifests()
.clusterBy(f -> 1)
.commit();

// check pre-condition
Assert.assertEquals(DataOperations.REPLACE, table.currentSnapshot().operation());

Dataset<Row> df = spark.readStream()
.format("iceberg")
.option(SparkReadOptions.READ_STREAM_SKIP_REPLACE, "true")
.load(tableIdentifier);

Assertions.assertThat(processAvailable(df))
.containsExactlyInAnyOrderElementsOf(Iterables.concat(dataAcrossSnapshots));
}

@SuppressWarnings("unchecked")

@SreeramGarlapati SreeramGarlapati Jul 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lookslike as if this is a new change. I guess your master is not up to date.

@Test
public void testReadStreamWithSnapshotTypeDeleteErrorsOut() throws Exception {
Expand Down