Make SparkWriteBuilder and SparkWrite classes public - #4
Open
daksha121 wants to merge 11 commits into
Open
Conversation
* idea checkpoint * implement skipDelete and skipReplace options * revert changes in SnapshotUtil
* implement skipDelete and skipReplace options * revert changes in SnapshotUtil
)" This reverts commit b6e3e7e.
…place Stream.read.ignore.delete.and.replace
| Assertions.assertThat(actual).containsExactlyInAnyOrderElementsOf(Iterables.concat(expected)); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") |
Collaborator
There was a problem hiding this comment.
this lookslike as if this is a new change. I guess your master is not up to date.
SreeramGarlapati
approved these changes
Jul 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some scenarios for which we need to support opinionated writes to Iceberg tables using Spark.
In an attempt to support those, we plan to extend the
SparkWriteBuilderandSparkWriteclasses. One example of the scenarios we are trying to achieve:Please let us know if there are alternative ways for us to support such functionality using Iceberg.